Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export hooks under Clojure-style names #58

Open
fricze opened this issue Jul 14, 2019 · 2 comments
Open

Export hooks under Clojure-style names #58

fricze opened this issue Jul 14, 2019 · 2 comments

Comments

@fricze
Copy link

fricze commented Jul 14, 2019

I'm pretty curious why hooks are exported in camelCase instead of, typical for Clojure, kebab-case? Since hx is Clojure(Script) lib it seems like kebab-case would be more "natural"?

@dpassen
Copy link

dpassen commented Oct 1, 2019

Just like create-context is.

@lilactown
Copy link
Collaborator

I agree with this now. At the time, I wanted to increase grepability of code written with hx and lean on google to surface docs for the React hooks.

However, the hooks that hx now provides are different enough than the fundamental hooks React provides now that trying to re-use their names doesn't add anything and reads and writes un-idiomatically in a Clojure codebase..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants