Skip to content

Commit 74c03f1

Browse files
author
LaRita Robinson
committed
Ensure that viewers show rather than thumbnails
1 parent 8c8f852 commit 74c03f1

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

app/helpers/pdf_js_helper_decorator.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ def external_pdf(presenter)
3333
end
3434

3535
def pdf_file_set_presenters(presenters)
36-
presenters.select(&:pdf?).presence || presenters.select do |file_set_presenter|
37-
file_set_presenter.solr_document["label_ssi"].downcase.end_with? ".pdf"
36+
presenters.select(&:pdf?).presence || presenters.select do |fsp|
37+
(fsp.solr_document['original_filename_tesi'] || fsp.solr_document['label_ssi'])&.downcase&.end_with?('.pdf')
3838
end
3939
end
4040

app/presenters/hyku/work_show_presenter_decorator.rb

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ def part_of_label
1212
# OVERRIDE incorporates fallback to PDF.js viewer via fileset's import_url
1313
# see also pdf_js_helper_decorator
1414
def show_pdf_viewer?
15-
return unless Flipflop.default_pdf_viewer? || !iiif_viewer?
16-
return unless file_set_presenters.any?(&:pdf?) || pdf_extension?
15+
return false unless Flipflop.default_pdf_viewer? || !iiif_viewer?
16+
return false unless file_set_presenters.any?(&:pdf?) || pdf_extension?
1717

1818
no_child_works?
1919
end
@@ -38,11 +38,17 @@ def no_child_works?
3838
end
3939

4040
def pdf_extension?
41-
file_set_presenters.any? { |fsp| fsp&.label&.downcase&.end_with?('.pdf') }
41+
# Valkyrie works are apparently not getting label assigned, but earlier works
42+
# used label for file name. Using a combination of both.
43+
file_set_presenters.any? do |fsp|
44+
(fsp.solr_document['original_filename_tesi'] || fsp.solr_document['label_ssi'])&.downcase&.end_with?('.pdf')
45+
end
4246
end
4347

4448
def iiif_media?(presenter: representative_presenter)
45-
iiif_media_predicates.any? { |predicate| presenter.try(predicate) || presenter.try(:solr_document).try(predicate) }
49+
# override TenantConfig to include pdfs so we can use the UV regardless of the config
50+
predicates = (iiif_media_predicates + %i[pdf?]).uniq
51+
predicates.any? { |predicate| presenter.try(predicate) || presenter.try(:solr_document).try(predicate) }
4652
end
4753

4854
# Override Tenant Config

0 commit comments

Comments
 (0)