Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor shippingAddress & billingAddress #263

Open
summer-cook opened this issue Mar 9, 2023 · 0 comments
Open

refactor shippingAddress & billingAddress #263

summer-cook opened this issue Mar 9, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@summer-cook
Copy link
Contributor

summer-cook commented Mar 9, 2023 •
edited
Loading

story

the requests are being configured to use the variables shippingAddress and billingAddress, but coming in from the api they are just shipping & billing.
we can make some stuff more clean if we change them to match.

acceptance

  • for configureRequests method configurations.js shippingAddress & billingAddress are changed to shipping and billing
  • this is updated throughout the app (and component library if needed)
  • the requestData method in requests.js is updated to only take in the request as opposed to request, shipping, and billing
@summer-cook summer-cook converted this from a draft issue Mar 9, 2023
@summer-cook summer-cook removed the status in webstore Mar 9, 2023
@alishaevn alishaevn removed this from webstore Mar 13, 2023
@alishaevn alishaevn changed the title refactor shippingAddress & billingAddress in configureRequests to shipping & billing, & change everywhere refactor shippingAddress & billingAddress Jan 17, 2024
@alishaevn alishaevn added the good first issue Good for newcomers label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alishaevn @summer-cook