From 90add69e17b16dcce0ecb2cbc35d6c671a7ba12a Mon Sep 17 00:00:00 2001 From: valentunn <70131744+valentunn@users.noreply.github.com> Date: Wed, 11 Dec 2024 11:51:27 +0000 Subject: [PATCH 01/18] Revert "chore(deps): bump raptorq from 1.8.1 to 2.0.0 in /rust (#2372)" This reverts commit d31f5534f1a794dbf05207eac7eadc6be03bb61c. --- rust/Cargo.lock | 4 ++-- rust/qr_reader_phone/Cargo.toml | 2 +- rust/qrcode_rtx/Cargo.toml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/rust/Cargo.lock b/rust/Cargo.lock index a06ccd8c7c..9b81d5cb16 100644 --- a/rust/Cargo.lock +++ b/rust/Cargo.lock @@ -3001,9 +3001,9 @@ dependencies = [ [[package]] name = "raptorq" -version = "2.0.0" +version = "1.8.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "90b1b1fad69672f0b901b5004863ea4307f03d168a3db5f2bcba4d3dfed88e97" +checksum = "7cc8cd0bcb2d520fff368264b5a6295e064c60955349517d09b14473afae4856" [[package]] name = "rayon" diff --git a/rust/qr_reader_phone/Cargo.toml b/rust/qr_reader_phone/Cargo.toml index 9524bef1a1..c7df0a3a68 100644 --- a/rust/qr_reader_phone/Cargo.toml +++ b/rust/qr_reader_phone/Cargo.toml @@ -8,7 +8,7 @@ edition = "2018" [dependencies] hex = "0.4.3" -raptorq = "2.0.0" +raptorq = "1.8.1" nom = "7.1.3" thiserror = "1.0.57" constants = {path = "../constants"} diff --git a/rust/qrcode_rtx/Cargo.toml b/rust/qrcode_rtx/Cargo.toml index e1af43c162..05a2f73da5 100644 --- a/rust/qrcode_rtx/Cargo.toml +++ b/rust/qrcode_rtx/Cargo.toml @@ -9,7 +9,7 @@ edition = "2018" [dependencies] bitvec = "1.0.1" hex = "0.4.3" -raptorq = "2.0.0" +raptorq = "1.8.1" qrcodegen = "1.8.0" png = "0.17.13" From 52687e1a77729566903f04b9e9b94705a4d77ab0 Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Wed, 11 Dec 2024 18:32:23 +0300 Subject: [PATCH 02/18] fix: allow ded_code --- rust/generate_message/src/error.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/rust/generate_message/src/error.rs b/rust/generate_message/src/error.rs index 7c745c1821..bb186f6e04 100644 --- a/rust/generate_message/src/error.rs +++ b/rust/generate_message/src/error.rs @@ -530,6 +530,7 @@ impl std::fmt::Display for Changed { /// /// Expected to receive data in hexadecimal format, got something different. /// [`NotHexActive`] specifies what was expected. +#[allow(dead_code)] #[derive(Debug)] pub enum NotHexActive { /// Network genesis hash, fetched through RPC call. From ce94d20dfd8d70886a8ac60276d0a0b285f72c79 Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Wed, 11 Dec 2024 18:32:23 +0300 Subject: [PATCH 03/18] fix: permission for semantic workflow --- .github/workflows/semantic.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/semantic.yml b/.github/workflows/semantic.yml index b4d3db0362..87a20dc322 100644 --- a/.github/workflows/semantic.yml +++ b/.github/workflows/semantic.yml @@ -7,6 +7,10 @@ on: - edited - synchronize +permissions: + pull-requests: read + + jobs: main: # By default, these PR titles are allowed: From 34fdabfe812e3a02123ae4a612997fcd4aea4503 Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Wed, 11 Dec 2024 18:32:23 +0300 Subject: [PATCH 04/18] fix: clippy --- rust/constants/src/lib.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/rust/constants/src/lib.rs b/rust/constants/src/lib.rs index 8f70170e71..a102404cd2 100644 --- a/rust/constants/src/lib.rs +++ b/rust/constants/src/lib.rs @@ -13,13 +13,13 @@ //! //! - [`SPECSTREE`], with network specs in cold database format //! - [`VERIFIERS`], with network verifiers, i.e. data on who user trusts to -//! sign updates for a given network +//! sign updates for a given network //! - [`METATREE`], with network metadata //! - [`ADDRTREE`], with user addresses public information //! - [`SETTREE`], containing general verifier, types information, and Vault -//! danger status +//! danger status //! - [`TRANSACTION`], used to store temporarily transaction data while the -//! user accepts or declines it +//! user accepts or declines it //! - [`HISTORY`], with history log //! //! Hot database contains following trees: @@ -34,7 +34,7 @@ //! //! - tree names in cold database alone or shared between cold and hot databases //! - key names in [`SPECSTREE`] tree of cold database alone or shared between -//! cold and hot databases +//! cold and hot databases //! - recurring throughout the Vault seed phrase for Alice //! - QR graphic settings, used for both static and animated PNG QR codes //! @@ -43,7 +43,7 @@ //! air-gapped device. It includes: //! //! - keys for [`TRANSACTION`] tree, used for temporary storage for various -//! kinds of transactions while they are shown to user for approval +//! kinds of transactions while they are shown to user for approval //! - display settings for history log and word guesser //! //! Feature `"active"` corresponds to all Vault-related things happening @@ -54,7 +54,7 @@ //! - default color settings for network specs //! - default files and folders name fragments, for use with `generate_message` //! - fountain qr generation parameters (large apng fountain qr codes are -//! generated only on the hot side) +//! generated only on the hot side) //! //! Feature `"test"` includes all `"signer"` and `"active"` contents, and some //! recurring data for integration testing, such as known identicons and known From 3fc6061b9f625c7ab3105c8a65ba8291821c82ca Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Wed, 11 Dec 2024 18:32:23 +0300 Subject: [PATCH 05/18] fix: change semantic permission to write --- .github/workflows/semantic.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/semantic.yml b/.github/workflows/semantic.yml index 87a20dc322..81c6ddd29a 100644 --- a/.github/workflows/semantic.yml +++ b/.github/workflows/semantic.yml @@ -8,8 +8,7 @@ on: - synchronize permissions: - pull-requests: read - + pull-requests: write jobs: main: From 5d0f4d913ebf0faa6b2cfd6e3d96cdb9e4d5e7b9 Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Wed, 11 Dec 2024 18:32:23 +0300 Subject: [PATCH 06/18] fix: change token usage --- .github/workflows/semantic.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/semantic.yml b/.github/workflows/semantic.yml index 81c6ddd29a..d047921067 100644 --- a/.github/workflows/semantic.yml +++ b/.github/workflows/semantic.yml @@ -18,10 +18,16 @@ jobs: runs-on: ubuntu-latest steps: + - uses: tibdex/github-app-token@v1 + id: generate-token + with: + app_id: ${{ secrets.NOVASAMA_APP_ID }} + private_key: ${{ secrets.NOVASAMA_APP_PRIVATE_KEY }} + # Documentation: https://github.com/amannn/action-semantic-pull-request - uses: amannn/action-semantic-pull-request@e9fabac35e210fea40ca5b14c0da95a099eff26f # v5.4.0 env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + GITHUB_TOKEN: ${{ steps.generate-token.outputs.token }} with: types: | major From 42d57bbb5a3d2345d93663d5eb782d7cc39685bb Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Wed, 11 Dec 2024 18:32:23 +0300 Subject: [PATCH 07/18] fix: pull_request event --- .github/workflows/semantic.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/semantic.yml b/.github/workflows/semantic.yml index d047921067..2425a870ea 100644 --- a/.github/workflows/semantic.yml +++ b/.github/workflows/semantic.yml @@ -1,11 +1,12 @@ name: Semantic PR on: - pull_request_target: - types: - - opened - - edited - - synchronize + # pull_request_target: + # types: + # - opened + # - edited + # - synchronize + pull_request: permissions: pull-requests: write From 6f95c9804f8bf1ba2f2e33793e04488322018d5e Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Wed, 11 Dec 2024 18:32:23 +0300 Subject: [PATCH 08/18] fix: add concurency --- .github/workflows/actions.yml | 4 ++++ .github/workflows/android-app.yml | 4 ++++ .github/workflows/android-release.yml | 4 ++++ .github/workflows/docs.yml | 4 ++++ .github/workflows/rust-cargo-deny.yml | 4 ++++ .github/workflows/rust-clippy.yml | 4 ++++ .github/workflows/rust-fmt.yml | 4 ++++ .github/workflows/rust-test-android.yml | 4 ++++ .github/workflows/rust-test-ios.yml | 4 ++++ .github/workflows/semantic.yml | 4 ++++ 10 files changed, 40 insertions(+) diff --git a/.github/workflows/actions.yml b/.github/workflows/actions.yml index 31822d84c7..c621e225dc 100644 --- a/.github/workflows/actions.yml +++ b/.github/workflows/actions.yml @@ -1,5 +1,9 @@ name: E2E Test +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + on: pull_request: push: diff --git a/.github/workflows/android-app.yml b/.github/workflows/android-app.yml index 0103523492..8f168b6fe9 100644 --- a/.github/workflows/android-app.yml +++ b/.github/workflows/android-app.yml @@ -1,5 +1,9 @@ name: Build android app +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + on: pull_request: push: diff --git a/.github/workflows/android-release.yml b/.github/workflows/android-release.yml index 5caac2416f..2fd966c4e4 100644 --- a/.github/workflows/android-release.yml +++ b/.github/workflows/android-release.yml @@ -1,5 +1,9 @@ name: Release android app +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + on: workflow_dispatch: jobs: diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index 104537dc8e..cacde40f3f 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -1,5 +1,9 @@ name: Check links and Publish Docs +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + on: pull_request: push: diff --git a/.github/workflows/rust-cargo-deny.yml b/.github/workflows/rust-cargo-deny.yml index ef64547b22..1f0305f942 100644 --- a/.github/workflows/rust-cargo-deny.yml +++ b/.github/workflows/rust-cargo-deny.yml @@ -1,5 +1,9 @@ name: Check cargo deny +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + on: pull_request: push: diff --git a/.github/workflows/rust-clippy.yml b/.github/workflows/rust-clippy.yml index 41aa1a1ae0..7934ab70a5 100644 --- a/.github/workflows/rust-clippy.yml +++ b/.github/workflows/rust-clippy.yml @@ -1,5 +1,9 @@ name: Rust clippy +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + on: pull_request: push: diff --git a/.github/workflows/rust-fmt.yml b/.github/workflows/rust-fmt.yml index ec9a97fda3..8f813f7290 100644 --- a/.github/workflows/rust-fmt.yml +++ b/.github/workflows/rust-fmt.yml @@ -1,5 +1,9 @@ name: Rustfmt +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + on: pull_request: push: diff --git a/.github/workflows/rust-test-android.yml b/.github/workflows/rust-test-android.yml index c6dde2dee3..d6380b3739 100644 --- a/.github/workflows/rust-test-android.yml +++ b/.github/workflows/rust-test-android.yml @@ -1,5 +1,9 @@ name: Rust backend test for android +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + on: pull_request: push: diff --git a/.github/workflows/rust-test-ios.yml b/.github/workflows/rust-test-ios.yml index c4b62e1de8..a4ef8d750d 100644 --- a/.github/workflows/rust-test-ios.yml +++ b/.github/workflows/rust-test-ios.yml @@ -1,5 +1,9 @@ name: Rust backend test for ios +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + on: pull_request: push: diff --git a/.github/workflows/semantic.yml b/.github/workflows/semantic.yml index 2425a870ea..0e408b3c84 100644 --- a/.github/workflows/semantic.yml +++ b/.github/workflows/semantic.yml @@ -1,5 +1,9 @@ name: Semantic PR +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: true + on: # pull_request_target: # types: From 3755b971677bea77e233ddeec72c4d7bc0176a31 Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Wed, 11 Dec 2024 18:32:23 +0300 Subject: [PATCH 09/18] fix: add actor --- .github/workflows/testflight-prod.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/testflight-prod.yml b/.github/workflows/testflight-prod.yml index 7a794a2127..61fe72398c 100644 --- a/.github/workflows/testflight-prod.yml +++ b/.github/workflows/testflight-prod.yml @@ -5,7 +5,7 @@ on: jobs: distribute_testflight: - if: contains('["krodak","prybalko"]', github.actor) + if: contains('["krodak","prybalko","stepanLav"]', github.actor) runs-on: macos-13 name: Distribute TestFlight Production Build From af1c8e5ba92f3a795b418e23db89df15fa01893d Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Wed, 11 Dec 2024 18:32:23 +0300 Subject: [PATCH 10/18] fix: lint problem --- rust/printing_balance/src/lib.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/rust/printing_balance/src/lib.rs b/rust/printing_balance/src/lib.rs index 73464bef94..dd62f3b3e0 100644 --- a/rust/printing_balance/src/lib.rs +++ b/rust/printing_balance/src/lib.rs @@ -27,7 +27,6 @@ fn assist(a: String, decimals: u8, order: u8) -> (String, Option, i8) { /// Input `balance` has to be a printed number. Likely `u128` or `u64`. /// Validity of input is checked elsewhere. - pub fn convert_balance_pretty(balance: &str, decimals: u8, units: &str) -> PrettyOutput { let order = (balance.len() as u8) - 1; From a5331e4217b26eb1b0c5d74fffe22701ea8c1084 Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Wed, 11 Dec 2024 18:32:23 +0300 Subject: [PATCH 11/18] fix: change signing cecrt --- ios/PolkadotVault.xcodeproj/project.pbxproj | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ios/PolkadotVault.xcodeproj/project.pbxproj b/ios/PolkadotVault.xcodeproj/project.pbxproj index a83161709c..f61f3b7992 100644 --- a/ios/PolkadotVault.xcodeproj/project.pbxproj +++ b/ios/PolkadotVault.xcodeproj/project.pbxproj @@ -3220,10 +3220,10 @@ ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; ASSETCATALOG_COMPILER_GLOBAL_ACCENT_COLOR_NAME = accent_pink300; CODE_SIGN_IDENTITY = "Apple Development"; - CODE_SIGN_STYLE = Manual; + CODE_SIGN_STYLE = Automatic; CURRENT_PROJECT_VERSION = 1; DEVELOPMENT_ASSET_PATHS = "\"PolkadotVault/Preview Content\""; - DEVELOPMENT_TEAM = ""; + DEVELOPMENT_TEAM = QXCVVJ6654; ENABLE_BITCODE = NO; ENABLE_PREVIEWS = YES; INFOPLIST_FILE = PolkadotVault/Info.plist; @@ -3255,7 +3255,7 @@ BUNDLE_LOADER = "$(TEST_HOST)"; CLANG_ENABLE_MODULES = YES; CODE_SIGN_STYLE = Automatic; - DEVELOPMENT_TEAM = 4GK8JWU7P9; + DEVELOPMENT_TEAM = QXCVVJ6654; "EXCLUDED_ARCHS[sdk=iphonesimulator*]" = arm64; INFOPLIST_FILE = PolkadotVaultTests/Info.plist; LD_RUNPATH_SEARCH_PATHS = ( @@ -3280,7 +3280,7 @@ BUNDLE_LOADER = "$(TEST_HOST)"; CLANG_ENABLE_MODULES = YES; CODE_SIGN_STYLE = Automatic; - DEVELOPMENT_TEAM = P2PX3JU8FT; + DEVELOPMENT_TEAM = QXCVVJ6654; INFOPLIST_FILE = PolkadotVaultTests/Info.plist; LD_RUNPATH_SEARCH_PATHS = ( "$(inherited)", @@ -3398,7 +3398,7 @@ BUNDLE_LOADER = "$(TEST_HOST)"; CLANG_ENABLE_MODULES = YES; CODE_SIGN_STYLE = Automatic; - DEVELOPMENT_TEAM = 4GK8JWU7P9; + DEVELOPMENT_TEAM = QXCVVJ6654; INFOPLIST_FILE = PolkadotVaultTests/Info.plist; LD_RUNPATH_SEARCH_PATHS = ( "$(inherited)", From 6bd30a9f83c0dcdc7951a602cb986b2d36313854 Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Wed, 11 Dec 2024 18:33:12 +0300 Subject: [PATCH 12/18] fix: change appfile --- ios/fastlane/Appfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ios/fastlane/Appfile b/ios/fastlane/Appfile index 25e0fa1873..f442699b0d 100644 --- a/ios/fastlane/Appfile +++ b/ios/fastlane/Appfile @@ -1,4 +1,4 @@ app_identifier "io.parity.NativeSigner" -apple_id "krzysztof@novasama.io" +apple_id "stepan@novasama.io" team_name "Novasama Technologies GmbH" -team_id "QXCVVJ6654" +team_id "ARXX83KX9T" From 94c3acfa70da20925b50411cb09fc1e90789774d Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Wed, 11 Dec 2024 18:33:14 +0300 Subject: [PATCH 13/18] change team id --- ios/fastlane/Appfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ios/fastlane/Appfile b/ios/fastlane/Appfile index f442699b0d..1b58274e56 100644 --- a/ios/fastlane/Appfile +++ b/ios/fastlane/Appfile @@ -1,4 +1,4 @@ app_identifier "io.parity.NativeSigner" apple_id "stepan@novasama.io" team_name "Novasama Technologies GmbH" -team_id "ARXX83KX9T" +team_id "QXCVVJ6654" From e3fbd6feac0e036bc952d3b161f5c112ec94a2c5 Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Wed, 11 Dec 2024 18:33:14 +0300 Subject: [PATCH 14/18] fix: semantic triggers --- .github/workflows/semantic.yml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/semantic.yml b/.github/workflows/semantic.yml index 0e408b3c84..f22ef42e67 100644 --- a/.github/workflows/semantic.yml +++ b/.github/workflows/semantic.yml @@ -5,12 +5,11 @@ concurrency: cancel-in-progress: true on: - # pull_request_target: - # types: - # - opened - # - edited - # - synchronize - pull_request: + pull_request_target: + types: + - opened + - edited + - synchronize permissions: pull-requests: write From 36738bde00b11ad17196ff54e421ab04266cef8d Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Wed, 11 Dec 2024 18:33:14 +0300 Subject: [PATCH 15/18] fix: change actors --- .github/workflows/testflight-prod.yml | 2 +- .github/workflows/testflight-qa.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/testflight-prod.yml b/.github/workflows/testflight-prod.yml index 61fe72398c..24d0fe4a91 100644 --- a/.github/workflows/testflight-prod.yml +++ b/.github/workflows/testflight-prod.yml @@ -5,7 +5,7 @@ on: jobs: distribute_testflight: - if: contains('["krodak","prybalko","stepanLav"]', github.actor) + if: contains('["krodak","ERussel"]', github.actor) runs-on: macos-13 name: Distribute TestFlight Production Build diff --git a/.github/workflows/testflight-qa.yml b/.github/workflows/testflight-qa.yml index 5c3b3c3159..b63717d812 100644 --- a/.github/workflows/testflight-qa.yml +++ b/.github/workflows/testflight-qa.yml @@ -5,7 +5,7 @@ on: jobs: distribute_testflight: - if: contains('["krodak","prybalko"]', github.actor) + if: contains('["krodak","ERussel"]', github.actor) runs-on: macos-13 name: Distribute TestFlight QA Build From 751843c4360afc16c876ecd3b02453adfa1ba6b8 Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Wed, 11 Dec 2024 18:33:14 +0300 Subject: [PATCH 16/18] fix: remove unnecessary changes --- rust/constants/src/lib.rs | 12 ++++++------ rust/printing_balance/src/lib.rs | 1 + 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/rust/constants/src/lib.rs b/rust/constants/src/lib.rs index a102404cd2..8f70170e71 100644 --- a/rust/constants/src/lib.rs +++ b/rust/constants/src/lib.rs @@ -13,13 +13,13 @@ //! //! - [`SPECSTREE`], with network specs in cold database format //! - [`VERIFIERS`], with network verifiers, i.e. data on who user trusts to -//! sign updates for a given network +//! sign updates for a given network //! - [`METATREE`], with network metadata //! - [`ADDRTREE`], with user addresses public information //! - [`SETTREE`], containing general verifier, types information, and Vault -//! danger status +//! danger status //! - [`TRANSACTION`], used to store temporarily transaction data while the -//! user accepts or declines it +//! user accepts or declines it //! - [`HISTORY`], with history log //! //! Hot database contains following trees: @@ -34,7 +34,7 @@ //! //! - tree names in cold database alone or shared between cold and hot databases //! - key names in [`SPECSTREE`] tree of cold database alone or shared between -//! cold and hot databases +//! cold and hot databases //! - recurring throughout the Vault seed phrase for Alice //! - QR graphic settings, used for both static and animated PNG QR codes //! @@ -43,7 +43,7 @@ //! air-gapped device. It includes: //! //! - keys for [`TRANSACTION`] tree, used for temporary storage for various -//! kinds of transactions while they are shown to user for approval +//! kinds of transactions while they are shown to user for approval //! - display settings for history log and word guesser //! //! Feature `"active"` corresponds to all Vault-related things happening @@ -54,7 +54,7 @@ //! - default color settings for network specs //! - default files and folders name fragments, for use with `generate_message` //! - fountain qr generation parameters (large apng fountain qr codes are -//! generated only on the hot side) +//! generated only on the hot side) //! //! Feature `"test"` includes all `"signer"` and `"active"` contents, and some //! recurring data for integration testing, such as known identicons and known diff --git a/rust/printing_balance/src/lib.rs b/rust/printing_balance/src/lib.rs index dd62f3b3e0..73464bef94 100644 --- a/rust/printing_balance/src/lib.rs +++ b/rust/printing_balance/src/lib.rs @@ -27,6 +27,7 @@ fn assist(a: String, decimals: u8, order: u8) -> (String, Option, i8) { /// Input `balance` has to be a printed number. Likely `u128` or `u64`. /// Validity of input is checked elsewhere. + pub fn convert_balance_pretty(balance: &str, decimals: u8, units: &str) -> PrettyOutput { let order = (balance.len() as u8) - 1; From 65fb4f9d7f356f412ba138bb1db3ab0a2bc12afb Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Wed, 11 Dec 2024 18:33:14 +0300 Subject: [PATCH 17/18] fix: return semantic run back --- .github/workflows/semantic.yml | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/workflows/semantic.yml b/.github/workflows/semantic.yml index f22ef42e67..016566e512 100644 --- a/.github/workflows/semantic.yml +++ b/.github/workflows/semantic.yml @@ -22,16 +22,10 @@ jobs: runs-on: ubuntu-latest steps: - - uses: tibdex/github-app-token@v1 - id: generate-token - with: - app_id: ${{ secrets.NOVASAMA_APP_ID }} - private_key: ${{ secrets.NOVASAMA_APP_PRIVATE_KEY }} - # Documentation: https://github.com/amannn/action-semantic-pull-request - uses: amannn/action-semantic-pull-request@e9fabac35e210fea40ca5b14c0da95a099eff26f # v5.4.0 env: - GITHUB_TOKEN: ${{ steps.generate-token.outputs.token }} + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: types: | major From 95b351f2ad3b33235df3b417d8d49e425c7a3d7d Mon Sep 17 00:00:00 2001 From: Stepan Lavrentev Date: Wed, 11 Dec 2024 18:35:12 +0300 Subject: [PATCH 18/18] fix: temp add stepanLav --- .github/workflows/testflight-prod.yml | 2 +- .github/workflows/testflight-qa.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/testflight-prod.yml b/.github/workflows/testflight-prod.yml index 24d0fe4a91..935b2d68c5 100644 --- a/.github/workflows/testflight-prod.yml +++ b/.github/workflows/testflight-prod.yml @@ -5,7 +5,7 @@ on: jobs: distribute_testflight: - if: contains('["krodak","ERussel"]', github.actor) + if: contains('["krodak","ERussel","stepanLav"]', github.actor) runs-on: macos-13 name: Distribute TestFlight Production Build diff --git a/.github/workflows/testflight-qa.yml b/.github/workflows/testflight-qa.yml index b63717d812..9db441a895 100644 --- a/.github/workflows/testflight-qa.yml +++ b/.github/workflows/testflight-qa.yml @@ -5,7 +5,7 @@ on: jobs: distribute_testflight: - if: contains('["krodak","ERussel"]', github.actor) + if: contains('["krodak","ERussel","stepanLav"]', github.actor) runs-on: macos-13 name: Distribute TestFlight QA Build