Skip to content

Commit 14048ba

Browse files
committed
The function seems to be duplicate.
1 parent 634a1d2 commit 14048ba

File tree

3 files changed

+12
-23
lines changed

3 files changed

+12
-23
lines changed

scripts/dockerfile-functions.sh

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
##!/bin/sh
22
echo "docker build setup"
33

4+
REGISTRY="${REGISTRY:-registry.npohosting.nl}"
5+
NAMESPACE=${NAMESPACE:-poms}
6+
47
TXT_HI="\e[93m" && TXT_CLEAR="\e[0m"
58

69
# scripts around the 'os_app_name' function, that determin the artifact name using information from Dockerfil
@@ -65,24 +68,4 @@ get_artifact_versions() {
6568
echo "Using image artifact: \"$IMAGE\" (tag: \"$IMAGE_TAG\", full: \"$FULL_IMAGE_NAME\")"
6669
}
6770

68-
echo "Define determine_image_version"
69-
determine_image_version() {
70-
if [ "$IMAGE_TAG" = '' ] ; then
71-
echo "No IMAGE_TAG defined. Breaking build. This must be defined in job rule!"
72-
exit 1
73-
fi
74-
if [ "$IMAGE_NAME" = '' ] ; then
75-
echo "No IMAGE_NAME defined. Taking from os_app_name"
76-
IMAGE_NAME=$(os_app_name)
77-
export IMAGE_NAME
78-
fi
79-
# used by plain docker builds
80-
if [ "$AS_LATEST" = 'true' ] ; then
81-
export LATEST="--destination $REGISTRY/$IMAGE_NAME"
82-
else
83-
export LATEST=
84-
fi
85-
export IMAGE=$REGISTRY/$IMAGE_NAME:$IMAGE_TAG
86-
echo "IMAGE: $IMAGE"
87-
}
8871

scripts/kaniko-functions.sh

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
##!/bin/sh
22
KANIKO_ARGS=${KANIKO_ARGS:-'--cache=true --cache-copy-layers=true'}
3-
REGISTRY="${REGISTRY:-registry.npohosting.nl}"
4-
NAMESPACE=${NAMESPACE:-poms}
3+
54
DOCKER_BUILD_ARGS=${DOCKER_BUILD_ARGS:-} # Uses eval, when overriding escape whitespace: '--build-arg\ "FOO=BAR"'
5+
AS_LATEST=${AS_LATEST:-'false'}
66

77

88
if ! type os_app_name &> /dev/null; then
@@ -68,6 +68,12 @@ kaniko_execute() {
6868
if [ ! -f "/kaniko/executor" ] ; then
6969
echo "kaniko/executor not found"
7070
return 1
71+
fi
72+
# used by plain docker builds
73+
if [ "$AS_LATEST" = 'true' ] ; then
74+
export LATEST="--destination $REGISTRY/$FULL_IMAGE_NAME"
75+
else
76+
export LATEST=
7177
fi
7278
echo Cache $REGISTRY/$NAMESPACE/caches
7379
/kaniko/executor $KANIKO_ARGS \
@@ -85,3 +91,4 @@ kaniko_execute() {
8591
--destination $image\
8692
--cleanup
8793
}
94+

scripts/kaniko-gitlab-functions.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
echo "kaniko gitlab functions"
1010

11-
AS_LATEST=${AS_LATEST:-'false'}
1211

1312
if [ -f job.env ] ; then
1413
echo "Found job.env!"

0 commit comments

Comments
 (0)