Skip to content

Commit b77f5d4

Browse files
committed
function was renamed
1 parent 68e8d9d commit b77f5d4

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

README.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ An advantage of this approach is that it can be used locally. Sometimes it is ju
2323
michiel@mitulo:(pomst)(main,80)~/npo/media/main/media-server$ ~/github/npo-poms/kaniko/kaniko.sh
2424
2 docker build setup
2525
38 defining os_app_name
26-
60 defining get_artifact_versions
26+
60 defining get_docker_image_name
2727
kaniko build setup
2828
Defining function setup_kaniko
2929
Defining function kaniko_execute

scripts/dockerfile-functions.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ os_app_name() {
3737
echo $appname
3838
}
3939

40-
echo "defining get_artifact_versions"
40+
echo "defining get_docker_image_name"
4141

4242
# exports PROJECT_VERSION, IMAGE_TAG, IMAGE, IMAGE_NAME
4343
# $1: directory containing the docker file
@@ -68,4 +68,8 @@ get_docker_image_name() {
6868
echo "Using image artifact: \"$IMAGE\" (tag: \"$IMAGE_TAG\", full: \"$FULL_IMAGE_NAME\")"
6969
}
7070

71+
#deprecated
72+
get_artifact_versions() {
73+
get_docker_image_name "$@"
74+
}
7175

scripts/kaniko-functions.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ run_kaniko_all() {
5959
store_variables
6060
}
6161

62-
# Stores relevant variables determined by get_artifact_versions in job.env
62+
# Stores relevant variables determined by get_docker_image_name in job.env
6363
# I'm not sure this is very useful. You can just as wel call get_articaft_versions again in the next job
6464
# which will have the same effect, but I think this is robust, because no need for fiddling with 'need=<previous job>',
6565
# which is confusing and error-prone.
@@ -109,7 +109,7 @@ kaniko_execute() {
109109

110110
if [ -z "$IMAGE" ] ; then
111111
echo "Missing IMAGE variable. Trying to find now by calling get_actifact_versions"
112-
get_artifact_versions $dir $version
112+
get_docker_image_name $dir $version
113113
fi
114114
image="$IMAGE"
115115
if [ -z "$image" ] ; then

0 commit comments

Comments
 (0)