[nrf noup] secure_fw: platform: Add system off service #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vge0rge
force-pushed
the
tfm_system_off
branch
2 times, most recently
from
9ea4ce7 to
b8c7971
Compare
frkv
reviewed
Nov 26, 2025
| * \details Requests the system to enter a low-power state. | ||
| */ | ||
| TFM_LINK_SET_RO_IN_PARTITION_SECTION("TFM_SP_PLATFORM", "PSA-ROT") | ||
| void tfm_platform_hal_system_off(void); |
Contributor
There was a problem hiding this comment.
Should be int-return for failure conditions
Contributor
Author
There was a problem hiding this comment.
I converted it to an enum tfm_platform_err_t as the other functions.
Vge0rge
force-pushed
the
tfm_system_off
branch
from
b8c7971 to
9cfd442
Compare
tomi-font
reviewed
Nov 26, 2025
Vge0rge
force-pushed
the
tfm_system_off
branch
2 times, most recently
from
3e47305 to
4a42770
Compare
tomi-font
reviewed
Nov 27, 2025
Collaborator
tomi-font
left a comment
tomi-font
left a comment
There was a problem hiding this comment.
Is this expected to then go upstream?
Contributor
Author
Not as is, there was a discussion with the TF-M maintainers and we both agree that something like this needs to be added upstream. Not sure if the naming will be the same. |
Add the tfm_platform_system_off APIs in a similar manner as the existing tfm_platform_system_reset. This API should enable implementations to allow setting the TF-M to the lowest power mode using their own HAL APIs. Right now this will work for isolation level 1 (SFN mode). In the IPC mode there is a need for better TF-M support for this. There is a discussion with the TF-M owners to add logic to TF-M so that it can inform all the partitions in order to make sure that it is safe to go to system off mode. Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>
Vge0rge
force-pushed
the
tfm_system_off
branch
from
b3ad068 to
3df8d8b
Compare
tomi-font
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the tfm_platform_system_off APIs in a similar manner as the existing tfm_platform_system_reset. This API should enable implementations to allow setting the TF-M to the lowest power mode using custom their own HAL APIs.
Right now this will work for isolation level 1 (SFN mode). In the IPC mode there is a need for better TF-M support for this. There is a discussion with the TF-M owners to add logic to TF-M so that it can inform all the partitions in order to make sure that it is safe to go to system off mode.