chore: lint

Author: nytamin

packages/connector/src/connection/mosMessageParser.ts

@@ -138,8 +138,8 @@ export class MosMessageParser extends EventEmitter<MosMessageParserEvents> {
 	}
 	private debugTrace(str: string) {
 		if (this.debug) {
-			// Supress console spam:
-			if (!`${str}`.match(/<heartbeat>/)) {
+			// Suppress console spam:
+			if (!/<heartbeat>/.exec(`${str}`)) {
 				// eslint-disable-next-line no-console
 				console.log(str)
 			}

packages/connector/src/connection/mosSocketClient.ts

@@ -101,7 +101,7 @@ export class MosSocketClient extends EventEmitter<MosSocketClientEvents> {
 			if (!this._lastConnectionAttempt || Date.now() - this._lastConnectionAttempt >= this._reconnectDelay) {
 				// !_lastReconnectionAttempt (means first attempt) OR time > _reconnectionDelay since last attempt
 				// recreate client if new attempt:
-				if (this._client && this._client.connecting) {
+				if (this._client?.connecting) {
 					this._client.destroy()
 					this._client.removeAllListeners()
 					delete this._client
@@ -274,8 +274,8 @@ export class MosSocketClient extends EventEmitter<MosSocketClientEvents> {
 	/**
 	 * convenience wrapper to expose all logging calls to parent object
 	 */
-	log(args: string | number | any): void {
-		this.debugTrace(args)
+	log(...args: any[]): void {
+		this.debugTrace(...args)
 	}
 	public setDebug(debug: boolean): void {
 		this._debug = debug
@@ -544,8 +544,8 @@ export class MosSocketClient extends EventEmitter<MosSocketClientEvents> {
 			}
 		}, this._commandTimeout)
 	}
-	private debugTrace(...strs: any[]) {
+	private debugTrace(...args: any[]) {
 		// eslint-disable-next-line no-console
-		if (this._debug) console.log(...strs)
+		if (this._debug) console.log(...args)
 	}
 }

packages/helper/src/mosModel/MosMessage.ts

@@ -29,7 +29,7 @@ export abstract class MosMessage {
 	prepare(messageID?: number): void {
 		if (!this.mosID) throw new Error(`Can't prepare message: mosID missing`)
 		if (!this.ncsID) throw new Error(`Can't prepare message: ncsID missing`)
-		this._messageID = messageID ? messageID : MosMessage.getNewMessageID()
+		this._messageID = messageID ?? MosMessage.getNewMessageID()
 	}
 
 	/** */

packages/helper/src/mosModel/parseMosTypes.ts

@@ -215,7 +215,7 @@ function getSpecialMosTypes(strict: boolean) {
 		validate: (_value: string) => true,
 		valueOf: (value: string) => value,
 		stringify: (value: string) => value,
-		is: (value: string | any): value is string => typeof value !== 'string',
+		is: (value: any): value is string => typeof value !== 'string',
 		fallback: () => '',
 	}
 	const stringEnum: MosType<string, string, { enum: { [key: string]: string }; value: AnyXMLValue }> = {
@@ -237,7 +237,7 @@ function getSpecialMosTypes(strict: boolean) {
 		validate: (_value: string) => true,
 		valueOf: (value: string) => value,
 		stringify: (value: string) => value,
-		is: (value: string | any): value is string => typeof value !== 'string',
+		is: (value: any): value is string => typeof value !== 'string',
 		fallback: () => '',
 	}
 	const number: MosType<number, number, AnyXMLValue> = {
@@ -248,7 +248,7 @@ function getSpecialMosTypes(strict: boolean) {
 		validate: (_value: number) => true,
 		valueOf: (value: number) => value,
 		stringify: (value: number) => `${value}`,
-		is: (value: number | any): value is number => typeof value !== 'number',
+		is: (value: any): value is number => typeof value !== 'number',
 		fallback: () => 0,
 	}
 

packages/helper/src/mosModel/profile1/xmlConversion.ts

@@ -27,7 +27,7 @@ export namespace XMLMosAck {
 
 			const ack: IMOSAck = {
 				ID: mosTypes.mosString128.createRequired(xml.objID, 'objID'),
-				Revision: mosTypes.number.createOptional(xml.objRev, 'objRev') || 0,
+				Revision: mosTypes.number.createOptional(xml.objRev, 'objRev') ?? 0,
 				Status:
 					mosTypes.stringEnum.createOptional({ value: xml.status, enum: IMOSAckStatus }, 'status') ||
 					IMOSAckStatus.ACK,

packages/model/src/mosTypes/mosDuration.ts

@@ -11,7 +11,7 @@ export function create(anyValue: AnyValue, strict: boolean): IMOSDuration {
 	if (typeof anyValue === 'number') {
 		value = anyValue
 	} else if (typeof anyValue === 'string') {
-		const m = anyValue.match(/(\d+):(\d+):(\d+)/)
+		const m = /(\d+):(\d+):(\d+)/.exec(anyValue)
 		if (!m) throw new Error(`MosDuration: Invalid input format: "${anyValue}"!`)
 
 		const hh: number = parseInt(m[1], 10)