From 7ef38e2e6d7029c4b4f43ad0473bf96365f92e0e Mon Sep 17 00:00:00 2001 From: Jan Starzak Date: Tue, 13 Feb 2024 11:43:08 +0100 Subject: [PATCH] chore: perf improvement --- packages/apps/client/src/model/UISegment.ts | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/packages/apps/client/src/model/UISegment.ts b/packages/apps/client/src/model/UISegment.ts index 790947f..e021943 100644 --- a/packages/apps/client/src/model/UISegment.ts +++ b/packages/apps/client/src/model/UISegment.ts @@ -58,16 +58,13 @@ export class UISegment { } get linesInOrder(): UILine[] { - return Array.from(this.lines.values()) - .slice() - .sort((a, b) => a.rank - b.rank) + return Array.from(this.lines.values()).sort((a, b) => a.rank - b.rank) } get linesInOrderFiltered(): UILine[] { - return Array.from(this.lines.values()) - .slice() - .filter(this.doesLineMatchFilter) - .sort((a, b) => a.rank - b.rank) + let lines = Array.from(this.lines.values()) + if (this.owner.filter) lines = lines.filter(this.doesLineMatchFilter) + return lines.sort((a, b) => a.rank - b.rank) } private doesLineMatchFilter = (line: UILine): boolean => {