Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete cookie doesn't delete cookies with CAPITAL keys #42

Open
vasilakisfil opened this issue Jun 2, 2017 · 2 comments
Open

Delete cookie doesn't delete cookies with CAPITAL keys #42

vasilakisfil opened this issue Jun 2, 2017 · 2 comments

Comments

@vasilakisfil
Copy link

Is this intentional?

show_me_the_cookies/lib/show_me_the_cookies/adapters/rack_test.rb

Line 26 in 2f81986

existing_cookie.name.downcase == cookie_name.to_s

@nruth
Copy link
Owner

nruth commented Apr 10, 2018

It certainly looks weird doesn't it. If there's no comment or test for it let's remove it because it's probably just leftover from when I was first playing around with getting something to work in my own app.

@vasilakisfil
Copy link
Author

will fix this and #31 on Thursday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nruth @vasilakisfil