👷 Remove guideline command.

- Separate Github community from guideline command
- Separate Git flow from guideline command

Author: romsi

built_in/git_flow.rb

@@ -0,0 +1,27 @@
+module Shift
+  module BuiltIn
+    class GitFlow
+
+      class ValidationError < ShiftError
+      end
+
+      def self.execute(arguments)
+        raise UnknownAction.new({message: "You should provide a valid action."}) unless !arguments[0].nil?
+        case arguments[0]
+        when :validate
+          GitFlow.validate
+        else
+          raise UnknownAction.new({message: "Unknown action: #{arguments[0]}."})
+        end
+      end
+
+      def self.validate
+        branches = BuiltIn::Sh.execute(["git branch -a"])
+        raise ValidationError.new({message: "master branch is missing."}) if branches.match(/remotes\/origin\/master/).nil?
+        raise ValidationError.new({message: "develop branch is missing."}) if branches.match(/remotes\/origin\/develop/).nil?
+        non_git_flow_branches = branches.scan(/remotes\/origin\/(?!(feature|develop|master|release|hotfix))(.+)/)
+        raise ValidationError.new({message: "The following branches are not compatible with Git flow: #{non_git_flow_branches.join(', ')}"}) if non_git_flow_branches.count > 0
+      end
+    end
+  end
+end

built_in/github_community.rb

@@ -0,0 +1,55 @@
+module Shift
+  module BuiltIn
+    class GithubCommunity
+
+      class UnknownAction < ShiftError
+      end
+
+      class ValidationError < ShiftErrors
+      end
+
+      def self.execute(arguments)
+        raise UnknownAction.new({message: "You should provide a valid action."}) unless !arguments[0].nil?
+        case arguments[0]
+        when :validate
+          GithubCommunity.validate
+        else
+          raise UnknownAction.new({message: "Unknown action: #{arguments[0]}."})
+        end
+      end
+
+      def self.validate
+        errors = []
+        errors.push({ severity: :error, message: "README.md is missing." }) if ! File.exists?("README.md")
+        GithubCommunity.validate_markdown("README.md", errors) if File.exists?("README.md")
+        errors.push({ severity: :error, message: "CONTRIBUTING.md is missing." }) if ! File.exists?("CONTRIBUTING.md")
+        GithubCommunity.validate_markdown("CONTRIBUTING.md", errors) if File.exists?("CONTRIBUTING.md")
+        errors.push({ severity: :warning, message: "MANIFESTO.md is missing." }) if ! File.exists?("MANIFESTO.md")
+        GithubCommunity.validate_markdown("MANIFESTO.md", errors) if File.exists?("MANIFESTO.md")
+        errors.push({ severity: :warning, message: "LICENSE is missing." }) if ! File.exists?("LICENSE")
+        errors.push({ severity: :warning, message: "CODE_OF_CONDUCT.md is missing." }) if ! File.exists?("CODE_OF_CONDUCT.md")
+        GithubCommunity.validate_markdown("CODE_OF_CONDUCT.md", errors) if File.exists?("CODE_OF_CONDUCT.md")
+        errors.push({ severity: :error, message: ".github is missing." }) if ! Dir.exist?(".github")
+        errors.push({ severity: :error, message: "ISSUE_TEMPLATE is missing." }) if ((! Dir.exist?(".github/ISSUE_TEMPLATE") || Dir.empty?(".github/ISSUE_TEMPLATE")) &&
+          (! Dir.exist?(".github/issue_template") || Dir.empty?(".github/issue_template")) &&
+          (! File.exists?(".github/ISSUE_TEMPLATE.md")) &&
+          (! File.exists?(".github/issue_template.md")))
+        errors.push({ severity: :error, message: "PULL_REQUEST_TEMPLATE is missing." }) if ((! Dir.exist?(".github/PULL_REQUEST_TEMPLATE") || Dir.empty?(".github/PULL_REQUEST_TEMPLATE")) &&
+          (! Dir.exist?(".github/pull_request_template") || Dir.empty?(".github/pull_request_template")) &&
+          (! File.exists?(".github/PULL_REQUEST_TEMPLATE.md")) &&
+          (! File.exists?(".github/pull_request_template.md")))
+        raise ValidationError.new(errors) if errors.count > 0
+      end
+
+      private
+
+      def self.validate_markdown(file_path, errors)
+        begin
+          BuiltIn::Markdown.validate(file_path)
+        rescue MarkdownError => markdown_error
+          errors.push({ severity: :error, message: markdown_error.message })
+        end
+      end
+    end
+  end
+end

built_in/guideline.rb

@@ -24,7 +24,7 @@ def execute(built_in_name, arguments)
     end
 
     def self.built_in_class_ref(built_in_name)
-      class_name = "BuiltIn::" + built_in_name.capitalize
+      class_name = "BuiltIn::" + built_in_name.shift_class
       begin
         return Shift.const_get(class_name)
       rescue NameError

built_in/guideline/github_community.rb

@@ -20,7 +20,7 @@ def self.execute(arguments)
           exit_status = thread.value.exitstatus
         end
         raise BuiltInFailed.new(result) if exit_status != 0
-        return true
+        return result
       end
     end
   end

built_in/service.rb

@@ -0,0 +1,34 @@
+require_relative "../../shift"
+
+mock_folder_name = "./spec/git_flow/mock"
+
+describe Shift::ShiftCore, "a user want to validate the presence of Git flow" do
+  context "with master branch missing" do
+    it "should not execute the :beta lane" do
+      core = Shift::ShiftCore.new
+      folder = Shift::ShiftFolder.new(mock_folder_name, 'missing_master')
+      expect { core.execute_lane(:beta, folder) }.to raise_error Shift::BuiltIn::GitFlow::ValidationError
+    end
+  end
+  context "with develop branch missing" do
+    it "should not execute the :beta lane" do
+      core = Shift::ShiftCore.new
+      folder = Shift::ShiftFolder.new(mock_folder_name, 'missing_develop')
+      expect { core.execute_lane(:beta, folder) }.to raise_error Shift::BuiltIn::GitFlow::ValidationError
+    end
+  end
+  context "with branch does not follow the Git flow standard" do
+    it "should not execute the :beta lane" do
+      core = Shift::ShiftCore.new
+      folder = Shift::ShiftFolder.new(mock_folder_name, 'not_follow_git_flow_standard')
+      expect { core.execute_lane(:beta, folder) }.to raise_error Shift::BuiltIn::GitFlow::ValidationError
+    end
+  end
+  context "with all the branches follow the Git flow standard" do
+    it "should execute the :beta lane" do
+      core = Shift::ShiftCore.new
+      folder = Shift::ShiftFolder.new(mock_folder_name, 'follow_git_flow_standard')
+      expect { core.execute_lane(:beta, folder) }.not_to raise_error
+    end
+  end
+end

built_in/sh.rb

@@ -0,0 +1,10 @@
+before_all do
+	sh "rm -rf /tmp/follow_git_flow_standard"
+	sh "mkdir /tmp/follow_git_flow_standard; cd /tmp/follow_git_flow_standard; git init; touch empty; git add .; git commit -m 'Initial commit'; git checkout -b remotes/origin/master; git checkout -b remotes/origin/develop; git checkout -b remotes/origin/feature/toto; git checkout -b remotes/origin/release/0.4.1; git checkout -b remotes/origin/hotfix/fix-ci"
+end
+
+lane :beta do
+	Dir.chdir("/tmp/follow_git_flow_standard") do
+		git_flow :validate
+	end
+end

spec/git_flow/git_flow_spec.rb

@@ -0,0 +1,10 @@
+before_all do
+	sh "rm -rf /tmp/missing_develop"
+	sh "mkdir /tmp/missing_develop; cd /tmp/missing_develop; git init; touch empty; git add .; git commit -m 'Initial commit'; git checkout -b remotes/origin/master"
+end
+
+lane :beta do
+	Dir.chdir("/tmp/missing_develop") do
+		git_flow :validate
+	end
+end

spec/git_flow/mock/follow_git_flow_standard

@@ -0,0 +1,10 @@
+before_all do
+	sh "rm -rf /tmp/missing_master"
+	sh "mkdir /tmp/missing_master; cd /tmp/missing_master; git init"
+end
+
+lane :beta do
+	Dir.chdir("/tmp/missing_master") do
+		git_flow :validate
+	end
+end