Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment written before loging in not submitted #49

Open
wildtype opened this issue Jul 14, 2018 · 2 comments
Open

Comment written before loging in not submitted #49

wildtype opened this issue Jul 14, 2018 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed javascript Pull requests that update Javascript code

Comments

@wildtype
Copy link
Collaborator

Steps to reproduce

  1. Without logging in, open pegelinux.id.
  2. Visit comments page.
  3. Write comment and submit.
  4. Login form shown. Fill with the right username and password, then login.

Actual condition

  1. Homepage shown after login.
  2. Comment written in step 3 not shown on comment page.

Expected condition

  1. Comment written in step 3 is submitted and shown after login success.

I'm not sure if this is a bug, or just not implemented yet. Feel free to remove the bug label and change this issue into feature suggestion/enhancement.

@wildtype wildtype added the bug Something isn't working label Jul 14, 2018
@nsiregar
Copy link
Owner

looks like it's not implemented yet, during login process we only catch previous url. we should implement this, it's kinda annoying when you write long comment then gone.

@wildtype wildtype added enhancement New feature or request and removed bug Something isn't working labels Jul 14, 2018
@wildtype
Copy link
Collaborator Author

I changed the label to enhancement. Reference for implementation: https://stackoverflow.com/a/32216213

Seems complicated. What about putting link to login page instead of comment form? Then after logged in, visitor will be redirected back to comments page.

@rezhajulio rezhajulio added help wanted Extra attention is needed javascript Pull requests that update Javascript code labels Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed javascript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

3 participants