Merge pull request #184 from nspcc-dev/new-golangci

Author: roman-khimov

.github/workflows/tests.yml

@@ -18,24 +18,9 @@ on:
 
 jobs:
   lint:
-    name: Lint
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          ref: ${{ github.event.inputs.ref }}
-
-      - uses: actions/setup-go@v5
-        with:
-          go-version-file: 'cmd/go.mod'
-          cache-dependency-path: cmd/go.sum
-
-      - name: golangci-lint
-        uses: golangci/golangci-lint-action@v4
-        with:
-          version: latest
-          working-directory: cmd
+    uses: nspcc-dev/.github/.github/workflows/go-linter.yml@master
+    with:
+      workdir: cmd
 
   codeql:
     name: CodeQL

.gitignore

@@ -1,5 +1,6 @@
 .idea
 .vscode
+.golangci.yml
 vendor
 .docker/ir/out/*
 !.docker/ir/out/.gitkeep

.golangci.yml

@@ -12,7 +12,7 @@ NEOBENCH_FROM_COUNT ?= 1
 NEOBENCH_TO_COUNT ?= 1
 MS_PER_BLOCK ?= 0
 
-.PHONY: help
+.PHONY: help lint
 
 # Show this help prompt
 help:
@@ -36,6 +36,13 @@ help:
 	start.SharpFourNodesGoRPC10wrk start.SharpFourNodesGoRPC30wrk start.SharpFourNodesGoRPC100wrk \
 	start.SharpFourNodesGoRPC25rate start.SharpFourNodesGoRPC50rate start.SharpFourNodesGoRPC60rate start.SharpFourNodesGoRPC300rate start.SharpFourNodesGoRPC1000rate
 
+.golangci.yml:
+	wget -O $@ https://github.com/nspcc-dev/.github/raw/master/.golangci.yml
+
+# Lint Go code
+lint: .golangci.yml
+	@cd cmd && golangci-lint run --config ../$<
+
 # Build all images
 build: gen build.node.bench build.node.go build.node.sharp build.bench
 

Makefile

@@ -190,7 +190,7 @@ func generateSharpConfig(templatePath, storageEngine, suffix string) error {
 	return nil
 }
 
-func writeJSON(path string, obj interface{}) error {
+func writeJSON(path string, obj any) error {
 	bytes, err := json.Marshal(obj)
 	if err != nil {
 		return err

cmd/config/main.go

@@ -166,7 +166,7 @@ func (c *RPCClient) GetBlockCount(ctx context.Context) (int, error) {
 	return num, c.doRPCCall(ctx, rpc, &num, c.blockRequester)
 }
 
-func (c *RPCClient) doRPCCall(_ context.Context, call string, result interface{}, client *fasthttp.Client) error {
+func (c *RPCClient) doRPCCall(_ context.Context, call string, result any, client *fasthttp.Client) error {
 	idx := c.inc.Add(1) % c.len
 
 	req, res := fasthttp.AcquireRequest(), fasthttp.AcquireResponse()