core: prevent access to uninitialized NotaryAssisted fee

AnnaShaleva · AnnaShaleva · commit 551f9ebb31e1 · 2024-06-07T19:46:37.000+03:00
Signed-off-by: Anna Shaleva &lt;shaleva.ann@nspcc.ru&gt;
diff --git a/pkg/core/blockchain.go b/pkg/core/blockchain.go
@@ -2117,6 +2117,9 @@ func (bc *Blockchain) GetNotaryBalance(acc util.Uint160) *big.Int {
 // per key which is a reward per notary request key for designated notary nodes.
 // Default value is returned if Notary contract is not yet active.
 func (bc *Blockchain) GetNotaryServiceFeePerKey() int64 {
+	if !bc.isHardforkEnabled(&transaction.NotaryAssistedActivation, bc.BlockHeight()) {
+		return 0
+	}
 	return bc.contracts.Policy.GetAttributeFeeInternal(bc.dao, transaction.NotaryAssistedT)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2117,6 +2117,9 @@ func (bc Blockchain) GetNotaryBalance(acc util.Uint160) big.Int {`
`2117`	`2117`	`// per key which is a reward per notary request key for designated notary nodes.`
`2118`	`2118`	`// Default value is returned if Notary contract is not yet active.`
`2119`	`2119`	`func (bc *Blockchain) GetNotaryServiceFeePerKey() int64 {`
	`2120`	`+ if !bc.isHardforkEnabled(&transaction.NotaryAssistedActivation, bc.BlockHeight()) {`
	`2121`	`+ return 0`
	`2122`	`+ }`
`2120`	`2123`	`return bc.contracts.Policy.GetAttributeFeeInternal(bc.dao, transaction.NotaryAssistedT)`
`2121`	`2124`	`}`
`2122`	`2125`