From 56cd68277ff4200535526cc13e82de089e08c5b6 Mon Sep 17 00:00:00 2001 From: Adrien Bertrand Date: Wed, 5 Jul 2023 18:10:22 +0200 Subject: [PATCH] ci: macOS: replace deprecated tool by new simpler one --- .github/workflows/macOS.yml | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/.github/workflows/macOS.yml b/.github/workflows/macOS.yml index 8266e875..71a2f53d 100644 --- a/.github/workflows/macOS.yml +++ b/.github/workflows/macOS.yml @@ -71,24 +71,17 @@ jobs: '/tmp/firebird-emu_macOS/'" eval "create-dmg $createDmgArgs" || eval "create-dmg $createDmgArgs" # We also retry just in case... - - name: "Notarize DMG" + - name: "[macOS] Notarize and staple DMG" env: HAVE_SECRETS: ${{ secrets.APPLE_NOTARIZATION_PASSWORD != '' }} + APPLE_NOTARIZATION_USERNAME: ${{ secrets.APPLE_NOTARIZATION_USERNAME }} + APPLE_NOTARIZATION_PASSWORD: ${{ secrets.APPLE_NOTARIZATION_PASSWORD }} + APPLE_NOTARIZATION_TEAMID: ${{ secrets.APPLE_NOTARIZATION_TEAMID }} if: ${{ runner.os == 'macOS' && github.repository == 'nspire-emus/firebird' && env.HAVE_SECRETS == 'true' }} - uses: adriweb/xcode-notarize-please@77452e14fadc0b5629870193e273c99623a1b320 # v1.2 - with: - product-path: firebird-emu_macOS.dmg - appstore-connect-username: ${{ secrets.APPLE_NOTARIZATION_USERNAME }} - appstore-connect-password: ${{ secrets.APPLE_NOTARIZATION_PASSWORD }} - primary-bundle-id: 'com.adriweb.firebird-emu' - - - name: "Staple DMG" - env: - HAVE_SECRETS: ${{ secrets.APPLE_NOTARIZATION_PASSWORD != '' }} - if: ${{ runner.os == 'macOS' && github.repository == 'nspire-emus/firebird' && env.HAVE_SECRETS == 'true' }} - uses: adriweb/xcode-staple@2114e06658d8492882b252406aaa7fee3e75ed85 # v1.0.0 - with: - product-path: firebird-emu_macOS.dmg + run: | + xcrun notarytool store-credentials "notarytool-profile" --apple-id "$APPLE_NOTARIZATION_USERNAME" --team-id "$APPLE_NOTARIZATION_TEAMID" --password "$APPLE_NOTARIZATION_PASSWORD" + xcrun notarytool submit "firebird-emu_macOS.dmg" --keychain-profile "notarytool-profile" --wait + xcrun stapler staple "firebird-emu_macOS.dmg" - name: "Upload DMG" uses: actions/upload-artifact@v3