Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: context.Context and timeouts #360

Open
jehiah opened this issue Jan 17, 2024 · 0 comments · May be fixed by #365
Open

*: context.Context and timeouts #360

jehiah opened this issue Jan 17, 2024 · 0 comments · May be fixed by #365

Comments

@jehiah
Copy link
Member

jehiah commented Jan 17, 2024

Go 1.7 added context.Context and it's been widely adopted for providing a way to control timeouts.

This ticket is to track adding context.Context to go-nsq in a way that provides control over connections so the caller can avoid unexpected long operations (like a TCP dial timeout when trying to Publish)

This replaces #210 and #211 and along with #311 provide more reliable publishing in some edge cases.

At Bitly we have an interest in pursuing this change - we will follow up with a specific proposal with a mind to implementing in a backwards compatible way, and with a look towards easy transition to a future v2 that might drop calls w/o a context. We also want to be identify any changes needed in the design of #311 ahead of time before that change lands.

cc: @mreiferson @ploxiln @zoemccormick @Ulminator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant