Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change internal classes to internal #868

Open
304NotModified opened this issue Mar 9, 2025 · 1 comment
Open

Change internal classes to internal #868

304NotModified opened this issue Mar 9, 2025 · 1 comment

Comments

@304NotModified
Copy link
Contributor

304NotModified commented Mar 9, 2025

Proposed for 6.0.

From #551:

  • Make the ReflectionExtensions helper internal and remove OrNull suffix as we use nullability for that.
  • Do not expose internal classes from Core namespace, but instead expose interfaces.
@Romfos
Copy link
Contributor

Romfos commented Mar 9, 2025

Part 1 is here: #869

Some core types are still public because they are used in public interfaces and change for them could be a bigger breaking change then proposed in this PR.

but in any case we can create part 2 with refactoring for other types

@304NotModified could you please investigate this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants