Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Vue version requirement and update outdated packages #424

Open
kikuomax opened this issue Jan 23, 2025 · 2 comments
Open

Increase Vue version requirement and update outdated packages #424

kikuomax opened this issue Jan 23, 2025 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@kikuomax
Copy link
Collaborator

kikuomax commented Jan 23, 2025

Description

I think we could require Vue 3.3 or higher. Btw, Vue 3.2.25 is a hidden break point.

I also want to update outdated build tools, and remove unused packages.

Why Buefy need this feature

Because newer versions of some build tools require Vue 3.3 or higher.

@kikuomax kikuomax added the enhancement New feature or request label Jan 23, 2025
@kikuomax kikuomax added this to the v0.2.1 milestone Jan 23, 2025
@kikuomax
Copy link
Collaborator Author

I found the type issue of the value attribute of <textarea>, which required a following ugly workaround, was fixed in Vue v3.4.6 or higher.

:value="computedValue === null ? undefined : computedValue"

@kikuomax
Copy link
Collaborator Author

kikuomax commented Jan 30, 2025

I found the following test fails with Vue from v3.4.0 to v3.4.12.

 FAIL  src/components/tabs/TabItem.spec.ts > BTabItem > should update active state
Error: Cannot call trigger on an empty DOMWrapper.
 ❯ Object.get ../../node_modules/@vue/test-utils/dist/vue-test-utils.cjs.js:1574:27
 ❯ src/components/tabs/TabItem.spec.ts:91:29
     89|         expect(wrapper.vm.isActive).toBe(false)
     90| 
     91|         await secondTabLink.trigger('click')
       |                             ^
     92|         expect(wrapperFirstItem.vm.isActive).toBe(false)
     93|         expect(wrapper.vm.isActive).toBe(true)

The changelog of Vue v3.4.13. I have not looked into the cause, but it should be related to the bug fixed in v3.4.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant