Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spacing in the Sidebar does not follow the Figma spec #1440

Closed
1 of 2 tasks
haideralsh opened this issue Sep 20, 2024 · 1 comment · Fixed by #1441
Closed
1 of 2 tasks

Spacing in the Sidebar does not follow the Figma spec #1440

haideralsh opened this issue Sep 20, 2024 · 1 comment · Fixed by #1441
Assignees
@haideralsh @nikola-nulogy
Labels
bug Something isn't working released

Comments

@haideralsh
Copy link
Contributor

Describe the bug

The overall padding and margins in the Sidebar are not using the spacing from the Figma UI kit. This is causing discrepancies between the design and the implementation.

Steps to reproduce

Inspect the padding and margins in Figma vs. Storybook

Expected behaviour

Equal padding and margins

Is your team blocked from moving forward by the bug?

No

Who would you like to fix the bug?

  • Myself
  • DesignOps

When do you need this by?

No response

Helpful resources

Figma UI kit

Additional context

No response
@haideralsh haideralsh added the bug Something isn't working label Sep 20, 2024
@melissap-nulogy melissap-nulogy linked a pull request Sep 20, 2024 that will close this issue
fix: Correct padding in sidebar header and footer #1441
Merged
7 tasks
@melissap-nulogy melissap-nulogy mentioned this issue Sep 20, 2024
Merged
7 tasks
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 10.2.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haideralsh haideralsh

@nikola-nulogy nikola-nulogy

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Correct padding in sidebar header and footer nulogy/design-system
2 participants
@haideralsh @nikola-nulogy