`sqruff` always changes the SQL files `mtime`, yielding a `nix fmt -- --ci`

[wucke13]

Describe the bug

sqruff always changes the SQL files mtime, yielding a failed nix fmt -- --ci.

To Reproduce

Format a file using sqruff. Run nix fmt -- --ci --verbose, to see that the file is reported as changed, despit git diff showing nothing. The only difference is the mtime.

Expected behavior

Ignore that the files mtime changed, as the file remains identical.

System information

NixOS 25.05

[wucke13]

Because of this I switched to sql-formatter, and I see the very same behavior :/

This seems to be a somewhat common problem, see #265

[jfly]

@wucke13, could you open issues with the upstream formatters?

[wucke13]

@jfly Done. Lets see how upstream reacts, while I agree that this is a semantic bug (modification time changed despite lack of actual modification), I'm not hugely optimistic that upstream will be willing to work around this.

[jfly]

Thanks! If you get any pushback, it might be helpful to point people to our formatter specification: https://treefmt.com/latest/reference/formatter-spec/

[wucke13]

Sqruff fixed it, sql-formatter wontfix.

[jfly]

Thanks @wucke13. I don't totally understand the sql-formatter discussion. It looks like you were asked to add prettier-plugin-sql to the equation and (for some reason) that affected the behavior? Then I see a mention of prettier-plugin-sql-cst.

What do you think we should do here in treefmt-nix? Should we drop the sql-formatter, or should we be using sql-formatter by way of prettier-plugin-sql?