Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid move not specific enough #1066

Open
nus-pe-bot opened this issue Nov 17, 2023 · 1 comment
Open

Invalid move not specific enough #1066

nus-pe-bot opened this issue Nov 17, 2023 · 1 comment

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 17, 2023

Steps to reproduce:

  1. Enter b to choose black for colour
  2. Enter 1 to choose difficulty level
  3. Enter move a1 a2

Expected:
Move is not valid and why

Actual:

Oops, that move isn't valid!

I think the message can be more specific to explain why the move isn't valid, since this program aims to help chess players train and learn how to play chess better and make learning and training accessible for beginners

image.png


[original: nus-cs2113-AY2324S1/pe-interim#1057] [original labels: severity.Low type.FeatureFlaw]
@antrikshdhand
Copy link

antrikshdhand commented Nov 20, 2023

Team's Response

I think the message can be more specific to explain why the move isn't valid, since this program aims to help chess players train and learn how to play chess better and make learning and training accessible for beginners

Having a chess game which explains why a move is not valid would be of great help to beginner chess players. However, this is a feature which was not in scope for v2.1 of ChessMaster. The goal for these 3 iterations was to set up a basic chess game which adhered to all the formal chess rules, and provided some basic features to the user such as checking the history of moves in the game. Hints or specific explanations were not part of our accepted user stories in this project, though we agree that this would be a great feature for a future version release.

Duplicate status (if any):

Duplicate of #1067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment