e2e tests: have Nuts containers wait for DB container healthy

Author: reinkrul

e2e-tests/oauth-flow/rfc021/do-test.sh

@@ -11,7 +11,9 @@ db_dc="docker compose -f docker-compose.yml -f ${1}.yml"
 echo "------------------------------------"
 echo "Cleaning up running Docker containers and volumes, and key material..."
 echo "------------------------------------"
-$db_dc down
+# --remove-orphans to ensure that DB containers of previous runs (on e.g. Postgres) are removed when testing with SQLite.
+# Nothing breaks otherwise, but it prevents annoying warnings in the log.
+$db_dc down --remove-orphans
 $db_dc rm -f -v
 
 echo "------------------------------------"

e2e-tests/oauth-flow/rfc021/mysql.yml

@@ -1,12 +1,14 @@
 services:
   nodeA-backend:
     depends_on:
-      - db
+      db:
+        condition: service_healthy
     environment:
       NUTS_STORAGE_SQL_CONNECTION: mysql://root:root@db:3306/node_a?charset=utf8mb4&parseTime=True&loc=Local
   nodeB-backend:
     depends_on:
-      - db
+      db:
+        condition: service_healthy
     environment:
       NUTS_STORAGE_SQL_CONNECTION: mysql://root:root@db:3306/node_b?charset=utf8mb4&parseTime=True&loc=Local
   db:

e2e-tests/oauth-flow/rfc021/postgres.yml

@@ -1,12 +1,14 @@
 services:
   nodeA-backend:
     depends_on:
-      - db
+      db:
+        condition: service_healthy
     environment:
       NUTS_STORAGE_SQL_CONNECTION: postgres://postgres:postgres@db:5432/node_a?sslmode=disable
   nodeB-backend:
     depends_on:
-      - db
+      db:
+        condition: service_healthy
     environment:
       NUTS_STORAGE_SQL_CONNECTION: postgres://postgres:postgres@db:5432/node_b?sslmode=disable
   db:

e2e-tests/oauth-flow/rfc021/sqlserver.yml

@@ -1,12 +1,14 @@
 services:
   nodeA-backend:
     depends_on:
-      - db
+      db:
+        condition: service_healthy
     environment:
       NUTS_STORAGE_SQL_CONNECTION: sqlserver://sa:MyStrong(!)Password@db:1433/node_a?sslmode=disable
   nodeB-backend:
     depends_on:
-      - db
+      db:
+        condition: service_healthy
     environment:
       NUTS_STORAGE_SQL_CONNECTION: sqlserver://sa:MyStrong(!)Password@db:1433/node_b?sslmode=disable
   db: