From 3c5e4d33ed343525169f1e01c0faa2bf449a64c0 Mon Sep 17 00:00:00 2001 From: Olga Bulat Date: Fri, 20 Sep 2024 18:28:21 +0300 Subject: [PATCH] fix: remove Storybook version from `storybook.ts` (#778) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ### ๐Ÿ”— Linked issue ### ๐Ÿ“š Description The Storybook versions in the `package.json` were updated, but the same change needs to be added to the `storybook.ts` to prevent version conflicts. Currently, with nightly, we get the following error: ``` WARN The following packages are incompatible with Storybook 8.2.7 as they depend on different major versions of Storybook packages: WARN - @nuxtjs/storybook@8.3.0-28764731.a9bf66d WARN Repo: https://storybook.nuxtjs.org WARN - @storybook-vue/nuxt@8.3.0-28764731.a9bf66d WARN Repo: https://storybook.nuxtjs.org WARN - storybook@8.2.9 WARN Repo: https://github.com/storybookjs/storybook/tree/next/code/lib/cli WARN - @storybook/vue3@8.2.9 WARN Repo: https://github.com/storybookjs/storybook/tree/next/code/renderers/vue3 WARN - @storybook/addon-links@8.2.9 WARN Repo: https://github.com/storybookjs/storybook/tree/next/code/addons/links WARN - @storybook/builder-vite@8.2.9 WARN Repo: https://github.com/storybookjs/storybook/tree/next/code/builders/builder-vite/#readme WARN - @storybook/addon-essentials@8.2.9 WARN Repo: https://github.com/storybookjs/storybook/tree/next/code/addons/essentials WARN - @storybook/addon-interactions@8.2.9 WARN Repo: https://github.com/storybookjs/storybook/tree/next/code/addons/interactions WARN - @storybook/test@8.2.9 WARN Repo: https://github.com/storybookjs/storybook/tree/next/code/lib/test WARN - @storybook/blocks@8.2.9 WARN Repo: https://github.com/storybookjs/storybook/tree/next/code/lib/blocks WARN WARN WARN Please consider updating your packages or contacting the maintainers for compatibility details. WARN For more on Storybook 8 compatibility, see the linked GitHub issue: WARN https://github.com/storybookjs/storybook/issues/26031 ERROR Storybook failed to load the following preset: @storybook-vue/nuxt/preset. nuxt:storybook:build 5:37:16 PM Please check whether your setup is correct, the Storybook dependencies (and their peer dependencies) are installed correctly and there are no package version clashes. ``` --- packages/nuxt-module/src/storybook.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/nuxt-module/src/storybook.ts b/packages/nuxt-module/src/storybook.ts index 75daff52..f86bff85 100644 --- a/packages/nuxt-module/src/storybook.ts +++ b/packages/nuxt-module/src/storybook.ts @@ -53,7 +53,6 @@ export async function setupStorybook(options: ModuleOptions, nuxt: Nuxt) { configDir: resolve(projectDir, './.storybook'), configType: 'DEVELOPMENT', cache: storybookCache, - packageJson: { version: '8.2.7' }, // Don't check for storybook updates (we're using the latest version) versionUpdates: false, quiet: options.logLevel < 4, // 4 = debug