Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svg files have black spots instead of color #19

Closed
alexgil1994 opened this issue Mar 28, 2019 · 2 comments
Closed

Svg files have black spots instead of color #19

alexgil1994 opened this issue Mar 28, 2019 · 2 comments
Labels

Comments

@alexgil1994
Copy link

Hello, thank you to both Nuxt and the creators of the module for providing it as a service for us Vue - Nuxt developers.

I wanted to test it before I start implementing it in personal projects. I used free SVG icons and illustrations found through the sites drawkit (which has some wonderful ones under MIT license) and flaticon.

You can see from my testing repository that some of them show black spots instead of their actual color and others (the dog and the hand) look as they should. Is this a problem of the svg files themselves, the svg-sprite-module or have I done something wrong?

I did some farther searching and found that such problems with black spots on svgs occurred in more Github repositories like ( 1, 2 ) so I guess it might be a generic svg problem?

You can find my testing repo at nuxt-svg-test

Steps to view the problem :

1). Clone the repo
2). Run npm install
3). Run npm run lint -- --fix
4). Run npm run dev

I installed the module, created the 2 needed folders in assets and imported the svg files. Then, I used them in the index.vue page as you can see after running the project.

Hopefully it isn't something complicating

Thank you for your time

@farnabaz
Copy link
Collaborator

Sorry for the late response
Should be fixed in next release by (569821c)

@galvez
Copy link

galvez commented May 26, 2019

thanks @farnabaz -- remember running into this as well :)

farnabaz added a commit that referenced this issue Jun 5, 2019
By definition, a defs sprite is not usable as a CSS sprite
fix #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants