Apply suggestions from code review

Co-authored-by: Tom Birdsong <40648863+tbirdso@users.noreply.github.com>
Signed-off-by: Victor Chang <mocsharp@users.noreply.github.com>

Author: mocsharp

CMakeLists.txt

@@ -25,7 +25,9 @@ list(APPEND CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/cmake/deps)
 include(HoloHubConfigHelpers)
 
 # Set install directory
-set(CMAKE_INSTALL_PREFIX "${CMAKE_SOURCE_DIR}/install")
+if(CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT)
+  set_property(CACHE CMAKE_INSTALL_PREFIX PROPERTY VALUE "${CMAKE_SOURCE_DIR}/install")
+endif()
 
 # Enable Testing
 include(CTest)

applications/endoscopy_tool_tracking/cpp/CMakeLists.txt

@@ -165,14 +165,12 @@ file(WRITE "${CMAKE_SOURCE_DIR}/install/endoscopy_tool_tracking_cpp/endoscopy_to
 
 install(
   DIRECTORY ${gxf_lstm_tensor_rt_inference_BINARY_DIR}/
-  DESTINATION "${CMAKE_SOURCE_DIR}/install/endoscopy_tool_tracking_cpp"
+  DESTINATION "endoscopy_tool_tracking_cpp"
   FILES_MATCHING PATTERN "*.so"
   PATTERN "CMakeFiles" EXCLUDE)
 
 install(
-  FILES
-    ${lstm_tensor_rt_inference_BINARY_DIR}/liblstm_tensor_rt_inference.so
-    ${tool_tracking_postprocessor_BINARY_DIR}/libtool_tracking_postprocessor.so
-  DESTINATION "${CMAKE_SOURCE_DIR}/install/endoscopy_tool_tracking_cpp"
+  TARGETS  lstm_tensor_rt_inference
+  DESTINATION "endoscopy_tool_tracking_cpp"
   COMPONENT "holohub-apps"
 )

applications/endoscopy_tool_tracking/python/CMakeLists.txt

@@ -66,26 +66,33 @@ endif()
 
 # Install application and dependencies into the install/ directory for packaging
 install(
-  FILES ${CMAKE_CURRENT_SOURCE_DIR}/endoscopy_tool_tracking.py
-  DESTINATION "${CMAKE_SOURCE_DIR}/install/endoscopy_tool_tracking_python"
+  FILES endoscopy_tool_tracking.py
+  DESTINATION "endoscopy_tool_tracking_python"
   COMPONENT "holohub-apps"
 )
 
 file(READ "${CMAKE_CURRENT_SOURCE_DIR}/endoscopy_tool_tracking.yaml" APP_YAML_FILE)
 string(REPLACE "gxf_extensions/lstm_tensor_rt_inference/" "" APP_YAML_FILE "${APP_YAML_FILE}")
-file(WRITE "${CMAKE_SOURCE_DIR}/install/endoscopy_tool_tracking_python/endoscopy_tool_tracking.yaml" "${APP_YAML_FILE}")
+file(WRITE "${CMAKE_CURRENT_BINARY_DIR}/packaging/endoscopy_tool_tracking.yaml" "${APP_YAML_FILE}")
+install(
+  FILE endoscopy_tool_tracking.yaml
+  DESTINATION endoscopy_tool_tracking_python
+  COMPONENT "holohub-apps"
+)
 
 install(
   DIRECTORY ${gxf_lstm_tensor_rt_inference_BINARY_DIR}/
-  DESTINATION "${CMAKE_SOURCE_DIR}/install/endoscopy_tool_tracking_python"
+  DESTINATION "endoscopy_tool_tracking_python"
   FILES_MATCHING PATTERN "*.so"
-  PATTERN "CMakeFiles" EXCLUDE)
+  PATTERN "CMakeFiles" EXCLUDE
+  COMPONENT "holohub-apps"  
+)
 
 install(
   FILES
     ${lstm_tensor_rt_inference_BINARY_DIR}/liblstm_tensor_rt_inference.so
     ${tool_tracking_postprocessor_BINARY_DIR}/libtool_tracking_postprocessor.so
-  DESTINATION "${CMAKE_SOURCE_DIR}/install/endoscopy_tool_tracking_python"
+  DESTINATION "endoscopy_tool_tracking_python"
   COMPONENT "holohub-apps"
 )