From 7383789d809ca662762d4208949f7c3ca409aaaa Mon Sep 17 00:00:00 2001 From: John Moon Date: Thu, 8 Aug 2024 11:46:31 -0700 Subject: [PATCH] Fix ANO linking warning Currently, when building an app that uses the Advanced Network Operator (ANO), CMake throws some warnings: ``` CMake Warning at operators/advanced_network/CMakeLists.txt:87 (target_link_libraries): Target "" requests linking to directory "/usr/lib/x86_64-linux-gnu". Targets may link only to libraries. CMake is dropping the item. ``` Like it says, there are directories being passed into target_link_libraries with -L which is not supported. Instead, let's use target_link_directories which is already being used in the ANO CMakeLists.txt file to pass those DPDK and DOCA directories. Signed-off-by: John Moon --- operators/advanced_network/CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/operators/advanced_network/CMakeLists.txt b/operators/advanced_network/CMakeLists.txt index f19aaecf5..2cf8e5846 100644 --- a/operators/advanced_network/CMakeLists.txt +++ b/operators/advanced_network/CMakeLists.txt @@ -83,8 +83,8 @@ target_compile_options(advanced_network_rx PUBLIC ${DPDK_CFLAGS}) target_compile_options(advanced_network_tx PUBLIC ${DPDK_CFLAGS}) target_link_libraries(advanced_network_common PUBLIC holoscan::core) -target_link_libraries(advanced_network_common PUBLIC -L${DPDK_LIBRARY_DIRS} ${DPDK_LIBRARIES} ${DPDK_EXTRA_LIBS}) -target_link_libraries(advanced_network_common PUBLIC -L${DOCA_LIBRARY_DIRS} -ldoca_gpunetio libdoca_gpunetio_device.a -ldoca_common -ldoca_argp -ldoca_eth -ldoca_flow) +target_link_directories(advanced_network_common PUBLIC ${DPDK_LIBRARY_DIRS} ${DOCA_LIBRARY_DIRS}) +target_link_libraries(advanced_network_common PUBLIC ${DPDK_LIBRARIES} ${DPDK_EXTRA_LIBS} -ldoca_gpunetio libdoca_gpunetio_device.a -ldoca_common -ldoca_argp -ldoca_eth -ldoca_flow) target_link_libraries(advanced_network_rx PUBLIC advanced_network_common) target_link_libraries(advanced_network_tx PUBLIC advanced_network_common)