Skip to content

Commit cce6d37

Browse files
authored
Fix ANO linking warning (#463)
Currently, when building an app that uses the Advanced Network Operator (ANO), CMake throws some warnings: ``` CMake Warning at operators/advanced_network/CMakeLists.txt:87 (target_link_libraries): Target "<target>" requests linking to directory "/usr/lib/x86_64-linux-gnu". Targets may link only to libraries. CMake is dropping the item. ``` Like it says, there are directories being passed into target_link_libraries with -L which is not supported. Instead, let's use target_link_directories which is already being used in the ANO CMakeLists.txt file to pass those DPDK and DOCA directories. Signed-off-by: John Moon <john.moon@vts-i.com>
1 parent 135b502 commit cce6d37

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

operators/advanced_network/CMakeLists.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ target_compile_options(advanced_network_rx PUBLIC ${DPDK_CFLAGS})
8383
target_compile_options(advanced_network_tx PUBLIC ${DPDK_CFLAGS})
8484

8585
target_link_libraries(advanced_network_common PUBLIC holoscan::core)
86-
target_link_libraries(advanced_network_common PUBLIC -L${DPDK_LIBRARY_DIRS} ${DPDK_LIBRARIES} ${DPDK_EXTRA_LIBS})
87-
target_link_libraries(advanced_network_common PUBLIC -L${DOCA_LIBRARY_DIRS} -ldoca_gpunetio libdoca_gpunetio_device.a -ldoca_common -ldoca_argp -ldoca_eth -ldoca_flow)
86+
target_link_directories(advanced_network_common PUBLIC ${DPDK_LIBRARY_DIRS} ${DOCA_LIBRARY_DIRS})
87+
target_link_libraries(advanced_network_common PUBLIC ${DPDK_LIBRARIES} ${DPDK_EXTRA_LIBS} -ldoca_gpunetio libdoca_gpunetio_device.a -ldoca_common -ldoca_argp -ldoca_eth -ldoca_flow)
8888
target_link_libraries(advanced_network_rx PUBLIC advanced_network_common)
8989
target_link_libraries(advanced_network_tx PUBLIC advanced_network_common)
9090

0 commit comments

Comments
 (0)