Skip to content

Commit

Permalink
App: Fix Endoscopy Tool Tracking C++ Test Config (#477)
Browse files Browse the repository at this point in the history
Fixes issue where Endoscopy Tool Tracking C++ tests were relying on the
default YAML configuration rather than the expected test configuration.

153bdfd updated the Endoscopy Tool Tracking C++ app CLI:
- Under previous behavior a configuration path could be passed as the
  0th positional argument
- Under new behavior a configuration path may be passed as a keyword
  `--config` argument. This brings the C++ app CLI into closer alignment
  with the existing `--data` argument and with the Python app CLI.

Prior to this fix, C++ test failures were observed:
- The test config file was not properly passed to the app under the new
  CLI. Instead the default test config was used, which does not define a
  stop condition and led to test timeout.
- The C++ render test failed due to relying on frame output from the
  test above.

Reproduced previous test failures locally and verified tests pass with
this fix applied.

Signed-off-by: Tom Birdsong <tbirdsong@nvidia.com>
  • Loading branch information
tbirdso authored and sohamm17 committed Sep 3, 2024
1 parent dfe5e28 commit db07645
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion applications/endoscopy_tool_tracking/cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ if(BUILD_TESTING)

# Add test
add_test(NAME endoscopy_tool_tracking_cpp_test
COMMAND endoscopy_tool_tracking ${CMAKE_CURRENT_BINARY_DIR}/endoscopy_tool_tracking_testing.yaml
COMMAND endoscopy_tool_tracking
--config ${CMAKE_CURRENT_BINARY_DIR}/endoscopy_tool_tracking_testing.yaml
--data "${HOLOHUB_DATA_DIR}/endoscopy"
WORKING_DIRECTORY ${CMAKE_BINARY_DIR})
set_tests_properties(endoscopy_tool_tracking_cpp_test PROPERTIES
Expand Down

0 comments on commit db07645

Please sign in to comment.