fix: jdtls throws errors equinox org jar not found #2

fix: jdtls setup fails due to unavailable equinox launcher org file

Author: s1n7ax

.github/workflows/jdtls-milestone-checker.yml

@@ -8,25 +8,38 @@ on:
     branches:
       - main
   workflow_dispatch:
+    inputs:
+      JDTLS_VERSION:
+        description: "jdtls version"
+        required: false
+      FORCE_REPACKAGE:
+        description: "Replace package already exists"
+        required: true
+        default: false
+        type: boolean
 
 permissions:
   contents: write
 
 jobs:
   check-and-release:
+    env:
+      JDTLS_VERSION: ${{ github.event.inputs.JDTLS_VERSION }}
+      FORCE_REPACKAGE: ${{ github.event.inputs.FORCE_REPACKAGE }}
     runs-on: ubuntu-latest
 
     steps:
       - name: Checkout repository
         uses: actions/checkout@v3
 
-      - name: Get latest jdtls version
-        id: get_latest
+      - name: Set the latest jdtls version
+        if: env.JDTLS_VERSION == ''
         run: |
           pip install requests
-          echo "latest_version=$(python ./get_latest.py)" >> $GITHUB_ENV
+          echo "JDTLS_VERSION=$(python ./get_latest.py)" >> $GITHUB_ENV
 
       - name: Check if latest version has been released
+        if: env.FORCE_REPACKAGE == 'false'
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
@@ -35,24 +48,28 @@ jobs:
             -H "Accept: application/vnd.github.v3+json" \
             https://api.github.com/repos/${{ github.repository }}/releases)
 
-          if echo "$releases" | jq -e '.[] | select(.tag_name == "${{ env.latest_version }}")' > /dev/null; then
-            echo "release_exists=true" >> $GITHUB_ENV
+          if echo "$releases" | jq -e '.[] | select(.tag_name == "${{ env.JDTLS_VERSION }}")' > /dev/null; then
+            echo "RELEASE_EXISTS=true" >> $GITHUB_ENV
           else
-            echo "release_exists=false" >> $GITHUB_ENV
+            echo "RELEASE_EXISTS=false" >> $GITHUB_ENV
           fi
 
       - name: Repackage jdtls
-        if: env.release_exists == 'false'
+        if: env.RELEASE_EXISTS == 'false' || env.FORCE_REPACKAGE == 'true'
         run: |
           pip install requests
           python ./repackage.py
           ls
 
+      - name: Debug
+        run: |
+          env
+
       - name: Release
-        if: env.release_exists == 'false'
+        if: env.RELEASE_EXISTS == 'false' || env.FORCE_REPACKAGE == 'true'
         uses: softprops/action-gh-release@v2
         with:
           files: jdtls.tar.gz
-          make_latest: "true"
-          name: "${{env.latest_version}}"
-          tag_name: "${{env.latest_version}}"
+          make_latest: "${{ github.event_name == 'scheduled' && 'true' || 'false' }}"
+          name: "${{env.JDTLS_VERSION}}"
+          tag_name: "${{env.JDTLS_VERSION}}"

repackage.py

@@ -1,11 +1,10 @@
 import re
 import requests
 from urllib.parse import urljoin
-import urllib.request
 import tarfile
 import os
 import tempfile
-from shutil import move, copyfile
+from shutil import copyfile 
 
 base_url = 'https://download.eclipse.org/jdtls/milestones/'
 
@@ -52,7 +51,10 @@ def extract_tar_gz(tar_gz_path, equinox_plugin_path):
         with tempfile.TemporaryDirectory() as tmp:
             ex_dir = f'{tmp}/jdtls'
             tar.extractall(path=ex_dir)
-            move(f'{ex_dir}/plugins/{equinox_plugin_path}', f'{ex_dir}/plugins/org.eclipse.equinox.launcher.jar')
+            # creating a hard link instead of moving the file
+            # https://github.com/nvim-java/release-jdtls/issues/1
+            os.link(f'{ex_dir}/plugins/{equinox_plugin_path}', f'{ex_dir}/plugins/org.eclipse.equinox.launcher.jar')
+            # move(f'{ex_dir}/plugins/{equinox_plugin_path}', f'{ex_dir}/plugins/org.eclipse.equinox.launcher.jar')
             with tempfile.TemporaryDirectory() as tmpout:
                 out_path = f'{tmpout}/jdtls.tar.gz'
                 with tarfile.open(out_path, "w:gz") as tarout:
@@ -61,7 +63,16 @@ def extract_tar_gz(tar_gz_path, equinox_plugin_path):
                 copyfile(f'{tmpout}/jdtls.tar.gz', './jdtls.tar.gz')
 
 
-version = get_latest_version()
+
+if os.environ.get('JDTLS_VERSION'):
+    is_custom_version = True
+    version = os.environ.get('JDTLS_VERSION')
+else:
+    is_custom_version = False
+    version = get_latest_version()
+
+print(f"re-packaging version {version}")
+
 download_url = get_jdtls_download_url(version)
 equinox_plugin_path = get_equinox_launcher_name(version)
 downloaded_path = download_file(download_url)