Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Merging one of the PRs that add support for base16-vim colorschemes #1187

Closed
titaniumtraveler opened this issue Jan 29, 2024 · 2 comments
Labels
new feature New feature or feature request

Comments

@titaniumtraveler
Copy link

Since around April last year there have been two PRs to add base16-vim support to lualine.

One by @JamyGolden (#1006) and one by me (#1081) in reaction to this issue #859.
(I didn't think to look for another PR solving the issue at that time.)

I'm currently using a custom colorscheme to add the same functionality to my config, (which basically contains the same code as my PR), but it would still be nice if lualine had builtin support for it.

Both PRs contain basically the same functionality, so it doesn't really matter, which one is merged.

@titaniumtraveler titaniumtraveler added the new feature New feature or feature request label Jan 29, 2024
@AntoinePrv
Copy link
Contributor

I'm also writing #1194 in this Context, since passing the cterm code from outside does change the values.

@shadmansaleh
Copy link
Member

resolved with #1006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or feature request
Projects
None yet
Development

No branches or pull requests

3 participants