Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing System.Data.SqlClient with the newer Microsoft.Data.SqlClient #383

Open
leedavi opened this issue Jun 12, 2024 · 3 comments

Comments

@leedavi
Copy link

leedavi commented Jun 12, 2024

Maybe look at swapping

using System.Data.SqlClient;

for

using Microsoft.Data.SqlClient;
@david-poindexter
Copy link
Member

@leedavi are you trying to report an issue or something? If so, can you please clarify? The title and description are unclear. Thanks.

@leedavi
Copy link
Author

leedavi commented Jun 19, 2024

@david-poindexter Sorry, for some reason GitHUb emails always go into my clutter folder and I missed them.

There is no problem. I was just pointing out Microsoft.Data.SqlClient is the replacement of System.Data.SqlClient. I'm sure they'll be no problem for years. From what I recall, it's just a straight swap.

I also noticed your drop database were not using SINGLE_USER, might be an idea to do that.

$"ALTER DATABASE [{this.dbName}] SET SINGLE_USER WITH ROLLBACK IMMEDIATE;DROP DATABASE [{this.dbName}] END";

@david-poindexter
Copy link
Member

Thank you for the clarification @leedavi. I will update the issue for clarity. If you want to create another issue for the drop database tip, feel free to do so.

@david-poindexter david-poindexter changed the title using Microsoft.Data.SqlClient; Consider replacing System.Data.SqlClient with the newer Microsoft.Data.SqlClient Jun 21, 2024
@david-poindexter david-poindexter added this to the Future: Minor milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants