Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate duplicated codes for Mole fraction at 100% humidity of carbon dioxide {CO2 CAS 124-38-9} {xCO2} in the atmosphere #99

Open
gwemon opened this issue Dec 4, 2021 · 2 comments
Assignees

Comments

@gwemon
Copy link
Contributor

gwemon commented Dec 4, 2021

The following 2 terms look identical in their current version: http://vocab.nerc.ac.uk/collection/P01/current/XCO2EQWT/ and http://vocab.nerc.ac.uk/collection/P01/current/XCO2WTAT/. THe former is linked to P02='TMES, the latter ACO2.

Check that the issue was not created when the terms were migrated to the new semnatic model, compare previous versions and deprecate the redundant code if necessary.

@roy-lowry
Copy link

roy-lowry commented Dec 4, 2021 via email

@roy-lowry
Copy link

Looked again, this time reading the definitions. Seem to remember SDN:P01::XCO2EQWT was set up as part of a set of codes for work @gwemon was doing for handling data from underway pCO2 systems of ships of opportunity. Might be worth looking at the whole set of codes to see if there is any significant difference between thee two. Does it matter whether or not the sample is within the analytical equipment? My instinctive answer is no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants