android: Ensure all localized strings for Norwegian are used.

A few third-party packages mistakenly provide their localized
strings for Norwegian with the incorrect 'no' locale tag (which
represents a macro language, not a real one), instead of 'nb',
the expected value.

As such, these strings were omitted from the build and missing
from APKs and bundles.

This fixes the issue by ensuring that 'no' strings are
recognized as 'nb' ones, if the package provides them.

This CL thus adds 'nb' strings for the following 13 string
resources in the Monochrome bundle:

  hats_lib_close_button_description
  hats_lib_default_prompt_title
  hats_lib_default_star_rating_bar_description
  hats_lib_default_thank_you
  hats_lib_next
  hats_lib_none_of_the_above
  hats_lib_open_text_hint
  hats_lib_open_text_no_pii
  hats_lib_prompt_no_thanks
  hats_lib_prompt_take_our_survey
  hats_lib_submit
  hats_lib_survey_page_number
  hats_lib_thank_you_followup_message

+ Disable pylint warnings properly now that of presubmit
  scripts have been fixed to parse the line-too-long
  directives properly [1]

[1] https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1396094

BUG=920960
R=​agrieve@chromium.org,benmason@chromium.org,estevenson@chromium.org,yfriedman@chromium.org

Change-Id: Ied74827c2e53c81f165b2fbcaec9f35d7e893290
Reviewed-on: https://chromium-review.googlesource.com/c/1437174
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#626341}(cherry picked from commit 1a5082d)
Reviewed-on: https://chromium-review.googlesource.com/c/1446191
Reviewed-by: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#64}
Cr-Branched-From: e510299-refs/heads/master@{#625896}

Author: digit-android

build/android/gyp/compile_resources.py

@@ -1,5 +1,5 @@
 #!/usr/bin/env python
-#
+# encoding: utf-8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
@@ -276,6 +276,11 @@ def _RenameLocaleResourceDirs(resource_dirs):
     * Modern ISO 639-1 codes will be renamed to their obsolete variant
       for Indonesian, Hebrew and Yiddish (e.g. 'values-in/ -> values-id/).
 
+    * Norwegian macrolanguage strings will be renamed to Bokmål (main
+      Norway language). See http://crbug.com/920960. In practice this
+      means that 'values-no/ -> values-nb/' unless 'values-nb/' already
+      exists.
+
     * BCP 47 langauge tags will be renamed to an equivalent ISO 639-1
       locale qualifier if possible (e.g. 'values-b+en+US/ -> values-en-rUS').
       Though this is not necessary at the moment, because no third-party
@@ -305,8 +310,8 @@ def _RenameLocaleResourceDirs(resource_dirs):
           raise Exception('Could not substitute locale %s for %s in %s' %
                           (locale, locale2, path))
         if os.path.exists(path2):
-          # This happens sometimes, e.g. the Android support library comes
-          # with both values-sr/ and values-b+sr+Latn/.
+          # This happens sometimes, e.g. some libraries provide both
+          # values-nb/ and values-no/ with the same content.
           continue
         build_utils.MakeDirectory(os.path.dirname(path2))
         shutil.move(path, path2)

build/android/gyp/util/resource_utils.py

@@ -40,6 +40,7 @@
     'iw': 'he',
     'in': 'id',
     'ji': 'yi',
+    'no': 'nb',  # 'no' is not a real language. http://crbug.com/920960
 }
 
 

build/android/gyp/util/resource_utils_test.py

@@ -25,13 +25,15 @@
     'copy_to_clipboard_failure_message': 'Lõikelauale kopeerimine ebaõnnestus'
 }
 
+# pylint: disable=line-too-long
 _EXPECTED_XML_1 = '''<?xml version="1.0" encoding="utf-8"?>
 <resources xmlns:android="http://schemas.android.com/apk/res/android">
 <string name="copy_to_clipboard_failure_message">"Lõikelauale kopeerimine ebaõnnestus"</string>
 <string name="low_memory_error">"Eelmist toimingut ei saa vähese mälu tõttu lõpetada"</string>
 <string name="opening_file_error">"Valit. faili avamine ebaõnnestus"</string>
 </resources>
 '''
+# pylint: enable=line-too-long
 
 _XML_RESOURCES_PREFIX = r'''<?xml version="1.0" encoding="utf-8"?>
 <resources xmlns:android="http://schemas.android.com/apk/res/android">
@@ -148,6 +150,7 @@ def test_ToAndroidLocaleName(self):
         'he-IL': 'iw-rIL',
         'id': 'in',
         'id-BAR': 'in-rBAR',
+        'nb': 'nb',
         'yi': 'ji'
     }
     for chromium_locale, android_locale in \
@@ -178,6 +181,8 @@ def test_ToChromiumLocaleName(self):
         'in': 'id',
         'in-rBAR': 'id-BAR',
         'id-rBAR': 'id-BAR',
+        'nb': 'nb',
+        'no': 'nb',  # http://crbug.com/920960
     }
     for android_locale, chromium_locale in \
         _TEST_ANDROID_TO_CHROMIUM_LOCALE_MAP.iteritems():