Skip to content

Commit d58c047

Browse files
Yash MalikYash Malik
authored andcommitted
VR: Stop creating keyboard for DLAs
We don't use the keyboard with we're launching Chrome VR for a DLA. Creating it unnecessarily means a startup slow-down of about 500ms - 1s. Bug: 804532 Change-Id: Idc351a7233a07047318845999c4ab5cc13c90dc6 Reviewed-on: https://chromium-review.googlesource.com/879092 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531101}(cherry picked from commit 371fc8f) Reviewed-on: https://chromium-review.googlesource.com/884101 Reviewed-by: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#61} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
1 parent 94357d6 commit d58c047

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

chrome/browser/android/vr_shell/vr_gl_thread.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ base::WeakPtr<VrShellGl> VrGLThread::GetVrShellGl() {
4646

4747
void VrGLThread::Init() {
4848
bool keyboard_enabled =
49-
base::FeatureList::IsEnabled(features::kVrBrowserKeyboard);
49+
base::FeatureList::IsEnabled(features::kVrBrowserKeyboard) &&
50+
!ui_initial_state_.web_vr_autopresentation_expected;
5051
if (keyboard_enabled) {
5152
keyboard_delegate_ = GvrKeyboardDelegate::Create();
5253
text_input_delegate_ = std::make_unique<vr::TextInputDelegate>();

0 commit comments

Comments
 (0)