Start replacing logrus with slog #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #63 +/- ##
==========================================
- Coverage 76.85% 67.80% -9.06%
==========================================
Files 3 4 +1
Lines 363 410 +47
==========================================
- Hits 279 278 -1
- Misses 59 107 +48
Partials 25 25
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
norkans7
force-pushed
the
slog
branch
3 times, most recently
from
e556baa
to
eb15bdf
Compare
norkans7
commented
Oct 13, 2023
| @@ -275,27 +275,26 @@ func (i *baseIndexer) indexBatch(index string, batch []byte) (int, int, error) { | |||
| createdCount, deletedCount, conflictedCount := 0, 0, 0 | |||
| for _, item := range response.Items { | |||
| if item.Index.ID != "" { | |||
| logrus.WithField("id", item.Index.ID).WithField("status", item.Index.Status).Trace("index response") | |||
| slog.Debug("index response", "id", item.Index.ID, "status", item.Index.Status) | |||
There was a problem hiding this comment.
slog has no Trace Level so I decided to use Debug level for this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.