Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] - shell completion #10

Open
nyxnor opened this issue Nov 18, 2021 · 8 comments
Open

[FEATURE REQUEST] - shell completion #10

nyxnor opened this issue Nov 18, 2021 · 8 comments
Labels
enhancement New feature or request

Comments

@nyxnor
Copy link
Owner

nyxnor commented Nov 18, 2021

Is your feature request related to a problem? Please describe.

Those are the most used shells and known to me that have completion (more to come if someone helps), I want that to be improved.

Describe the solution you'd like

Additional context

Low priority, it will be very useful but not intrinsic required.

@nyxnor nyxnor added the enhancement New feature or request label Nov 18, 2021
@nyxnor
Copy link
Owner Author

nyxnor commented Dec 3, 2021

Planning to move this to a new repository onionjuggler-shell-completion
This will avoid having bash and zsh code with posix, because of shellcheck and codefactor lintering.

@nyxnor nyxnor pinned this issue Aug 19, 2022
@nyxnor
Copy link
Owner Author

nyxnor commented Aug 20, 2022

@nyxnor
Copy link
Owner Author

nyxnor commented Aug 22, 2022

9a00d26

@nyxnor
Copy link
Owner Author

nyxnor commented Aug 22, 2022

8d36854

@nyxnor
Copy link
Owner Author

nyxnor commented Aug 22, 2022

ca13e72

nyxnor added a commit that referenced this issue Aug 22, 2022
nyxnor added a commit that referenced this issue Aug 23, 2022
@nyxnor
Copy link
Owner Author

nyxnor commented Aug 23, 2022

in the end it was only bash completion, because sh does not have one and I won't learn zsh completion.

Also, only possible to complete services by configuration, because it is readable.

Not possible to complete clients server and client side because it is owned by the tor user.

Also, if the completion was made, it would only be valid to the root user, and I don't want anyone running root user by default just for completion.

@nyxnor
Copy link
Owner Author

nyxnor commented Aug 23, 2022

What can be improved is service listing with comma the same way wget does https://github.com/scop/bash-completion/blob/40aa4dc3c75791f43f850871466039768b3048ad/completions/wget#L47

nyxnor added a commit that referenced this issue Aug 24, 2022
correct ignoring commented lines. #10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant