Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[o1vm] Ensure the instruction passed into the interpreter is the one pointed to by the IP #2573

Open
Fizzixnerd opened this issue Sep 18, 2024 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@Fizzixnerd
Copy link
Contributor

Or otherwise refactor it so no instruction is passed in, and we just use the opcode from the IP.

This is in, for instance, https://github.com/o1-labs/proof-systems/blob/master/o1vm/src/mips/interpreter.rs#L987 the interpret functions for the instructions.

@Fizzixnerd Fizzixnerd added the good first issue Good for newcomers label Sep 18, 2024
@varun-doshi
Copy link

Is this still open?
If so, I would like to take this up.
Some more context would be helpful

@Fizzixnerd
Copy link
Contributor Author

Hi there!

I'm currently working on this issue, sorry! This issue is part of the as-yet-unfinished o1vm work that we are doing, so I think it would be difficult to give more context until we've actually released the feature it's a part of. Sorry, I meant for the tag to be for people working on the VM already, I didn't mean to confuse!

@Fizzixnerd Fizzixnerd self-assigned this Sep 23, 2024
@varun-doshi
Copy link

No issues
Will look for other issues to get started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants