Merge pull request #37 from oalders/command

Try harder to run command -v

Author: oalders

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changes
 
+## 0.5.4 - 2024-08-16
+
+- Run "command -v" via "sh -c" (GH#37) (Olaf Alders)
+
 ## 0.5.3 - 2024-06-22
 
 - Parse versions for: dig, perldoc, fpp, fzf, screen, sqlite3 and typos (GH#35)

main.go

@@ -29,7 +29,7 @@ func main() {
 		kong.Name("is"),
 		kong.Description("an inspector for your environment"),
 		kong.UsageOnError(),
-		kong.Vars{"version": "0.5.3"},
+		kong.Vars{"version": "0.5.4"},
 	)
 
 	// Run kongplete.Complete to handle completion requests

test/is.bats

@@ -1,7 +1,9 @@
 #!/usr/bin/env bats
 
 @test "is --version" {
-  ./is --version
+  run ./is --version
+  [ "$status" -eq 0 ]
+  [ "$output" = "0.5.4" ]
 }
 
 @test "is --help" {

there.go

@@ -5,19 +5,22 @@ import (
 	"errors"
 	"log"
 	"os/exec"
+	"strings"
 
 	"github.com/oalders/is/types"
 )
 
 // Run "is there ...".
 func (r *ThereCmd) Run(ctx *types.Context) error {
-	cmd := exec.Command("command", "-v", r.Name) //nolint:gosec
+	args := []string{"-c", "command -v " + r.Name}
+	cmd := exec.Command("sh", args...)
 	if ctx.Debug {
-		log.Printf("Running \"command -v %s\"\n", r.Name)
+		log.Printf("Running \"sh %s\"\n", strings.Join(args, " "))
 	}
 	err := cmd.Run()
 	if err != nil {
 		if ctx.Debug {
+			log.Printf("Error was: %v\n", err)
 			log.Printf("Running \"which %s\"\n", r.Name)
 		}
 		cmd := exec.Command("which", r.Name) //nolint:gosec