Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONDecodeError when get_history datetimes are out of range #33

Open
humatic opened this issue Aug 21, 2016 · 0 comments
Open

JSONDecodeError when get_history datetimes are out of range #33

humatic opened this issue Aug 21, 2016 · 0 comments

Comments

@humatic
Copy link

humatic commented Aug 21, 2016

When the start and end times used with the get_history method are out of range, the exception is not properly handled. For example, this requests data for 2017 (it is now 2016). A JSONDecodeError results.

response = oanda.get_history(
    instrument='EUR_USD',
    granularity='M5',
    start=1503619200,
    end=1504051200
    )

I'm testing using a practice account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant