Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace the "force" column in the walltime_change table by "forced" #154

Open
npf opened this issue Jun 27, 2018 · 1 comment
Open

replace the "force" column in the walltime_change table by "forced" #154

npf opened this issue Jun 27, 2018 · 1 comment
Assignees
@npf
Labels
bug
Milestone
2.5.10

Comments

@npf
Copy link
Contributor

npf commented Jun 27, 2018

Force is a reserved work in mysql.
We can use force but postgres does not like it ! (commit a279642 is not ok)

Proposition is to rename to forced to avoid having to add a 'if mysql' in functions...

Also need to look at the update set ... FROM ... where... which mysql does not support -> confirm if fix in commit a279642 is ok for postgres.

Impacted: IO.pm and database structures and upgrade files.
@npf npf added the bug label Jun 27, 2018
@npf npf added this to the 2.5.8 milestone Jun 27, 2018
@npf npf self-assigned this Jun 27, 2018
@npf npf changed the title replace the force columns in the walltime_change table by forced replace the "force" column in the walltime_change table by "forced" Jun 27, 2018
@npf
Copy link
Contributor Author

npf commented Jan 5, 2019

commit reverted 733d318

@npf npf modified the milestones: 2.5.8, 2.5.9 Jan 5, 2019
@npf npf modified the milestones: 2.5.9, 2.5.10 Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@npf npf

Labels
bug
Projects
None yet
Milestone
2.5.10
Development

No branches or pull requests
1 participant
@npf