Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON examples missing #53

Closed
DavidFatDavidF opened this issue Nov 27, 2023 · 2 comments · Fixed by #75
Closed

JSON examples missing #53

DavidFatDavidF opened this issue Nov 27, 2023 · 2 comments · Fixed by #75
Assignees
@michmech
Labels
documentation Improvements or additions to documentation editorial serialization affects only one or more serializations but not the core or module data models
Milestone
1st public review

Comments

@DavidFatDavidF
Copy link
Contributor

Many JSON examples are missing (Ex 10, 26)
@DavidFatDavidF DavidFatDavidF added this to the 1st public review milestone Nov 27, 2023
@DavidFatDavidF
Copy link
Contributor Author

@michmech to implement by January 3, 2024

@DavidFatDavidF DavidFatDavidF added documentation Improvements or additions to documentation editorial serialization affects only one or more serializations but not the core or module data models labels Dec 20, 2023
@michmech michmech mentioned this issue Jan 4, 2024
Merged
@michmech
Copy link
Contributor

michmech commented Jan 4, 2024

  • Examples 10 and 26 look like this: "..." and they actually aren’t placeholders or anything, they are actual JSON examples. They show that the object in question is to be implemented in JSON as a string.
  • There are a total of 4 JSON examples like this in the entire document. I have added “Implemented as a string” to them to make it clear that this not an error.

Will close automatically when pull request #75 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michmech michmech

Labels
documentation Improvements or additions to documentation editorial serialization affects only one or more serializations but not the core or module data models
Projects
None yet
Milestone
1st public review
Development

Successfully merging a pull request may close this issue.

Implementing decisions taken on 20 Dec 2023 michmech/lexidma
2 participants
@DavidFatDavidF @michmech