Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate and fix empty strings for setting #588

Open
opsaaaaa opened this issue Dec 10, 2019 · 0 comments
Open

investigate and fix empty strings for setting #588

opsaaaaa opened this issue Dec 10, 2019 · 0 comments
Labels
bug Something isn't working question Further information is requested refactor Rewrite or refine existing functionality

Comments

@opsaaaaa
Copy link
Collaborator

find any setting that can be saved as empty strings
write a concern use_nil_for_blank on before_save replace the problematic settings that are blank with nil.
write a rake task to find all settings that are empty strings and replace them with strings.

we may decide to refactor the settings into a new model or a new column. if so this should be handled at the same time.

@opsaaaaa opsaaaaa added bug Something isn't working refactor Rewrite or refine existing functionality question Further information is requested labels Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested refactor Rewrite or refine existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant