Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with new additional AUR package #105

Closed
wants to merge 1 commit into from

Conversation

hisbaan
Copy link

@hisbaan hisbaan commented Oct 23, 2023

Hi there! I've added a -git package for the AUR here. I mainly made the package because of #103 being merged solving a critical issue for me with ZSH. This PR is just a small change to the README to reflect that.

While doing that, I noticed that the tags on the latest commits are incorrect, so if possible could you please fix that up? Right now, git describe --tags returns v1.0.3-46-gc95b22c when it should probably return something starting in v2.0.0 since that's the current release. This is because the tag associated with the latest commit hasn't been updated to the latest tag.

@@ -100,10 +100,10 @@ Download the binary from Github Releases and put it in your `$PATH`.

### From the AUR

Use your favorite AUR helper.
Use your favorite AUR helper to install `trashy` or `trashy-git`. Trashy git will remain up to date with the `master` branch.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be better to call out that the latest release version breaks tab completion, so new users don't go down a rabbit hole trying to fix it. Rather than just offering both versions with no context. At least until the release includes that fix.

@hisbaan hisbaan closed this by deleting the head repository Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants