Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate for_cdo option #152

Open
observingClouds opened this issue Oct 22, 2022 · 3 comments
Open

Deprecate for_cdo option #152

observingClouds opened this issue Oct 22, 2022 · 3 comments

Comments

@observingClouds
Copy link
Owner

The upcoming release of CDO (2.1.1) will better support temporal chunks >1 with a significant speed-up. After testing this claim, we might want to remove the for_cdo option, document that this is only necessary for cdo < 2.1.1 or raise a info message during execution.

if for_cdo: # take shape as chunksize and ensure time chunksize 1
if time_dim in da.dims:
time_axis_num = da.get_axis_num(time_dim)
chunksize = da.data.chunksize if da.chunks is not None else da.shape
# https://code.mpimet.mpg.de/boards/2/topics/12598
chunksize = list(chunksize)
chunksize[time_axis_num] = 1
chunksize = tuple(chunksize)
return chunksize

@fnhirwa
Copy link
Contributor

fnhirwa commented Feb 27, 2024

Hello @observingClouds I'm new to this tool and would like to work on this task😊
Is is open for contribution?

@observingClouds
Copy link
Owner Author

Hi @fnhirwa,
Thanks for your willingness to contribute! Have you worked with CDO (climate data operators) before and ideally with netCDF files? The code change is quite straightforward but we would like to do some performance testing here to check if the cdo option can be deprecated.

@fnhirwa
Copy link
Contributor

fnhirwa commented Feb 28, 2024

Hi @fnhirwa, Thanks for your willingness to contribute! Have you worked with CDO (climate data operators) before and ideally with netCDF files? The code change is quite straightforward but we would like to do some performance testing here to check if the cdo option can be deprecated.

Well, I haven't worked with CDO before but with proper documentation and my experience with diving into large codebases, I think I can quickly adopt also I want to get myself familiarized with the project as I wanted to apply for the GSOC program of this project. I'd appreciate guidance and resources to get started with the task, if it is hard for the project's first user then I would love to get another task that you find might help me to understand the codebase and use-cases in deep.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants