Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: NoteMover shortcut #5067

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bueckerlars
Copy link

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/bueckerlars/obsidian-note-mover-shortcut.git

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Add NoteMover shortcut plugin Add plugin: NoteMover shortcut Jan 4, 2025
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2]:Adding command to the command ID is not necessary, please remove it.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Jan 5, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Jan 5, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

@joethei
Copy link
Collaborator

joethei commented Jan 16, 2025

import * as path from "path";
This import is only available from a Node.js runtime, which means that this will throw errors on Mobile (that's a problem since you have isDesktopOnly marked as false in your manifest.json file.

path.join(targetFolder, file.name);
Just join them with a /, that is valid across all platforms when using the vault/FileManager API.

await app.vault.rename(file, newPath);
You should use the app.fileManager.renameFile function, as that will also update all the links pointing to this file.

// Credits go to Liam's Periodic Notes Plugin: https://github.com/liamcain/obsidian-periodic-notes
This code should no longer be used, implement a AbstractInputSuggest instead.

if (fileCache && fileCache.tags) {
You are not getting the tags that come from the frontmatter here, use getAllTags(fileCache);
The getAllTags method used here is from the Obsidian API, so make sure to avoid conflicts with your function.

.setName('Inbox Folder'), .setName('Note Folder'), 'Periodic Movement', .setName('Enable Periodic Movement'), .setName('Periodic Movement Interval'), .setName('Enable Filter'), .setName("Toggle Blacklist/Whitelist"), .setName('Enalbe Rules'), .setButtonText('Add new Rule')
Use sentence case in UI

notice.noticeEl.innerHTML = <b>NoteMover update</b>:<br/>${msg};, notice.noticeEl.innerHTML = <b>NoteMover info</b>:<br/>${msg};, notice.noticeEl.innerHTML = <b>NoteMover Error</b>:<br/>${e.message}<br/>Check console for more information;, notice.noticeEl.innerHTML = <b>NoteMover Error</b>:<br/>${e.message};
Avoid using innerHTML

@joethei joethei self-assigned this Jan 16, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants