Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git@githumb.com refs transformed into https://github.com refs #52

Open
Rosuavio opened this issue Jul 28, 2024 · 0 comments
Open

git@githumb.com refs transformed into https://github.com refs #52

Rosuavio opened this issue Jul 28, 2024 · 0 comments

Comments

@Rosuavio
Copy link

When a github repo cloned using the ssh url (e.g git@github.com:user/repo) is packed and unpacked it results in a repo with a https url for the remote (e.g https://github.com/user/repo).

The use of the ssh url is an important aspect of the thunk to some users, as pushing a change to a workflow file (anything in .github/workflows) is allowed by github using an ssh url, but refused by github using an https url.

While it seems like their could be user configuration that could be done to satisfy githubs security requirements, having a repo using an ssh url (that works for everything they need with their ssh keys configured on github) change to one using an https url that could require additional configuration is problematic.

When thunks are packed and unpacked it should preserve the schema (and probably everything else) in the uri of the remote.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant