Clang format on github run

Author: DDRBoxman

.clang-format

@@ -52,3 +52,5 @@ SpacesInParentheses: false
 SpacesInSquareBrackets: false
 TabWidth: 8
 UseTab: ForIndentation
+---
+Language: ObjC

.github/workflows/clang-format.yml

@@ -0,0 +1,42 @@
+name: Clang Format Check
+
+on: [push, pull_request]
+jobs:
+  ubuntu64:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+        with:
+          submodules: 'recursive'
+
+      - name: Install clang format
+        run: |
+          # gets us newer clang
+          sudo bash -c "cat >> /etc/apt/sources.list" << LLVMAPT
+          # 3.8
+          deb http://apt.llvm.org/xenial/ llvm-toolchain-xenial-8 main
+          deb-src http://apt.llvm.org/xenial/ llvm-toolchain-xenial-8 main
+          LLVMAPT
+          wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key|sudo apt-key add -    
+          sudo apt-get -qq update
+          sudo apt-get install -y clang-format-8
+      - name: Check the Formatting
+        run: |
+          ./formatcode.sh
+          ./CI/check-format.sh
+  macos64:
+    runs-on: macos-latest        
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+        with:
+          submodules: 'recursive'
+
+      - name: Install clang-format
+        run: |
+          brew install clang-format
+      - name: Check the Formatting
+        run: |
+          ./formatcode.sh
+          ./CI/check-format.sh

CI/check-format.sh

@@ -0,0 +1,11 @@
+#!/bin/bash
+dirty=$(git ls-files --modified)
+
+set +x
+if [[ $dirty ]]; then
+	echo "================================="
+    echo "Files were not formatted properly"
+    echo "$dirty"
+    echo "================================="
+    exit 1
+fi

formatcode.sh

@@ -0,0 +1,29 @@
+#!/usr/bin/env bash
+# Original source https://github.com/Project-OSRM/osrm-backend/blob/master/scripts/format.sh
+
+set +x
+set -o errexit
+set -o pipefail
+set -o nounset
+
+# Runs the Clang Formatter in parallel on the code base.
+# Return codes:
+#  - 1 there are files to be formatted
+#  - 0 everything looks fine
+
+# Get CPU count
+OS=$(uname)
+NPROC=1
+if [[ $OS = "Linux" || $OS = "Darwin" ]] ; then
+    NPROC=$(getconf _NPROCESSORS_ONLN)
+fi
+
+# Discover clang-format
+if type clang-format-8 2> /dev/null ; then
+    CLANG_FORMAT=clang-format-8
+else
+    CLANG_FORMAT=clang-format
+fi
+
+find . -type d -type f -o -name '*.h' -or -name '*.hpp' -or -name '*.m' -or -name '*.mm' -or -name '*.c' -or -name '*.cpp' \
+| xargs -I{} -P ${NPROC} ${CLANG_FORMAT} -i -style=file  -fallback-style=none {}

mac/EditorWidget-osx.mm

@@ -21,49 +21,46 @@
 #import "../headers/VSTPlugin.h"
 
 void EditorWidget::buildEffectContainer(AEffect *effect) {
-	cocoaViewContainer = new QMacCocoaViewContainer(nullptr, this);
-	cocoaViewContainer->move(0, 0);
-	cocoaViewContainer->resize(300, 300);
-	NSView *view = [[NSView alloc] initWithFrame:  NSMakeRect(0, 0,
-			300, 300)];
+  cocoaViewContainer = new QMacCocoaViewContainer(nullptr, this);
+  cocoaViewContainer->move(0, 0);
+  cocoaViewContainer->resize(300, 300);
+  NSView *view = [[NSView alloc] initWithFrame:NSMakeRect(0, 0, 300, 300)];
 
-	cocoaViewContainer->setCocoaView(view);
+  cocoaViewContainer->setCocoaView(view);
 
-	cocoaViewContainer->show();
+  cocoaViewContainer->show();
 
-	auto *hblParams  =new QHBoxLayout();
-	hblParams->setContentsMargins(0, 0, 0, 0);
-	hblParams->addWidget(cocoaViewContainer);
+  auto *hblParams = new QHBoxLayout();
+  hblParams->setContentsMargins(0, 0, 0, 0);
+  hblParams->addWidget(cocoaViewContainer);
 
-	VstRect* vstRect = nullptr;
-	effect->dispatcher (effect, effEditGetRect, 0, 0, &vstRect, 0);
-	if (vstRect)
-	{
-		NSRect frame = NSMakeRect(vstRect->left, vstRect->top,
-				vstRect->right, vstRect->bottom);
+  VstRect *vstRect = nullptr;
+  effect->dispatcher(effect, effEditGetRect, 0, 0, &vstRect, 0);
+  if (vstRect) {
+    NSRect frame = NSMakeRect(vstRect->left, vstRect->top, vstRect->right,
+                              vstRect->bottom);
 
-		[view setFrame:frame];
+    [view setFrame:frame];
 
-		cocoaViewContainer->resize(vstRect->right - vstRect->left,
-				vstRect->bottom- vstRect->top);
+    cocoaViewContainer->resize(vstRect->right - vstRect->left,
+                               vstRect->bottom - vstRect->top);
 
-		this->setGeometry(QRect(0,0,vstRect->right - vstRect->left,
-								vstRect->bottom- vstRect->top));
-	}
+    this->setGeometry(QRect(0, 0, vstRect->right - vstRect->left,
+                            vstRect->bottom - vstRect->top));
+  }
 
-	effect->dispatcher (effect, effEditOpen, 0, 0, view, 0);
+  effect->dispatcher(effect, effEditOpen, 0, 0, view, 0);
 
-
-	this->setLayout(hblParams);
+  this->setLayout(hblParams);
 }
 
 void EditorWidget::handleResizeRequest(int width, int height) {
-	resize(width, height);
-	cocoaViewContainer->resize(width, height);
-	NSView *view = cocoaViewContainer->cocoaView();
-	NSRect frame = NSMakeRect(0, 0, width, height);
+  resize(width, height);
+  cocoaViewContainer->resize(width, height);
+  NSView *view = cocoaViewContainer->cocoaView();
+  NSRect frame = NSMakeRect(0, 0, width, height);
 
-	[view setFrame:frame];
+  [view setFrame:frame];
 
-	this->setGeometry(QRect(0,0,width, height));
+  this->setGeometry(QRect(0, 0, width, height));
 }

mac/VSTPlugin-osx.mm

@@ -17,75 +17,67 @@
 
 #include "../headers/VSTPlugin.h"
 
-AEffect* VSTPlugin::loadEffect() {
-	AEffect* newEffect = NULL;
-
-	// Create a path to the bundle
-	CFStringRef pluginPathStringRef = CFStringCreateWithCString(NULL,
-			pluginPath.c_str(), kCFStringEncodingUTF8);
-	CFURLRef bundleUrl = CFURLCreateWithFileSystemPath
-			(kCFAllocatorDefault, pluginPathStringRef,
-			kCFURLPOSIXPathStyle, true);
-
-	if (bundleUrl == NULL)
-	{
-		blog(LOG_WARNING, "Couldn't make URL reference for VST plug-in");
-		return NULL;
-	}
-
-	// Open the bundle
-	bundle = CFBundleCreate(kCFAllocatorDefault, bundleUrl);
-	if (bundle == NULL)
-	{
-		blog(LOG_WARNING, "Couldn't create VST bundle reference.");
-		CFRelease(pluginPathStringRef);
-		CFRelease(bundleUrl);
-		return NULL;
-	}
-
-	vstPluginMain mainEntryPoint = NULL;
-	mainEntryPoint = (vstPluginMain) CFBundleGetFunctionPointerForName
-			(bundle, CFSTR("VSTPluginMain"));
-
-	// VST plugins previous to the 2.4 SDK used main_macho for the
-	// entry point name.
-	if (mainEntryPoint == NULL)
-	{
-		mainEntryPoint = (vstPluginMain)
-				CFBundleGetFunctionPointerForName(bundle,
-				CFSTR("main_macho"));
-	}
-
-	if (mainEntryPoint == NULL)
-	{
-		blog(LOG_WARNING, "Couldn't get a pointer to plug-in's main()");
-		CFBundleUnloadExecutable(bundle);
-		CFRelease(bundle);
-		return NULL;
-	}
-
-	newEffect = mainEntryPoint(hostCallback_static);
-	if (newEffect == NULL)
-	{
-		blog(LOG_WARNING, "VST Plug-in's main() returns null.");
-		CFBundleUnloadExecutable(bundle);
-		CFRelease(bundle);
-		return NULL;
-	}
-
-	newEffect->user = this;
-
-	// Clean up
-	CFRelease(pluginPathStringRef);
-	CFRelease(bundleUrl);
-
-	return newEffect;
+AEffect *VSTPlugin::loadEffect() {
+  AEffect *newEffect = NULL;
+
+  // Create a path to the bundle
+  CFStringRef pluginPathStringRef = CFStringCreateWithCString(
+      NULL, pluginPath.c_str(), kCFStringEncodingUTF8);
+  CFURLRef bundleUrl = CFURLCreateWithFileSystemPath(
+      kCFAllocatorDefault, pluginPathStringRef, kCFURLPOSIXPathStyle, true);
+
+  if (bundleUrl == NULL) {
+    blog(LOG_WARNING, "Couldn't make URL reference for VST plug-in");
+    return NULL;
+  }
+
+  // Open the bundle
+  bundle = CFBundleCreate(kCFAllocatorDefault, bundleUrl);
+  if (bundle == NULL) {
+    blog(LOG_WARNING, "Couldn't create VST bundle reference.");
+    CFRelease(pluginPathStringRef);
+    CFRelease(bundleUrl);
+    return NULL;
+  }
+
+  vstPluginMain mainEntryPoint = NULL;
+  mainEntryPoint = (vstPluginMain)CFBundleGetFunctionPointerForName(
+      bundle, CFSTR("VSTPluginMain"));
+
+  // VST plugins previous to the 2.4 SDK used main_macho for the
+  // entry point name.
+  if (mainEntryPoint == NULL) {
+    mainEntryPoint = (vstPluginMain)CFBundleGetFunctionPointerForName(
+        bundle, CFSTR("main_macho"));
+  }
+
+  if (mainEntryPoint == NULL) {
+    blog(LOG_WARNING, "Couldn't get a pointer to plug-in's main()");
+    CFBundleUnloadExecutable(bundle);
+    CFRelease(bundle);
+    return NULL;
+  }
+
+  newEffect = mainEntryPoint(hostCallback_static);
+  if (newEffect == NULL) {
+    blog(LOG_WARNING, "VST Plug-in's main() returns null.");
+    CFBundleUnloadExecutable(bundle);
+    CFRelease(bundle);
+    return NULL;
+  }
+
+  newEffect->user = this;
+
+  // Clean up
+  CFRelease(pluginPathStringRef);
+  CFRelease(bundleUrl);
+
+  return newEffect;
 }
 
 void VSTPlugin::unloadLibrary() {
-	if (bundle)
-	{
-		CFBundleUnloadExecutable(bundle);
-		CFRelease(bundle);
-	}
+  if (bundle) {
+    CFBundleUnloadExecutable(bundle);
+    CFRelease(bundle);
+  }
 }