Skip to content

Update cloud scheduler permission to AWS equivalent #2403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
faucomte97 opened this issue Feb 6, 2025 · 1 comment
Closed
2 tasks

Update cloud scheduler permission to AWS equivalent #2403

faucomte97 opened this issue Feb 6, 2025 · 1 comment
Labels
2025:tech debt 2025 Goal: Reduce technical debt

Comments

@faucomte97
Copy link
Contributor

Task Description

There are a couple of API endpoints on the old system that require the Google Cloud Scheduler permission to run.
See the last 2 endpoints in api.py.

The permission is defined in the appengine repo.

We need to convert this to the AWS equivalent to prep the system for the switch to OTP.
We need to make sure it's in place, but not activated yet. We will activate it only when we perform the switch.

Alternatively, it might be easier to convert these 2 API calls to cron jobs.

Acceptance Criteria

Either:

  • Update the permission to the equivalent role in AWS
    Or:
  • Convert the 2 API calls to cron jobs
@faucomte97 faucomte97 added the 2025:tech debt 2025 Goal: Reduce technical debt label Feb 6, 2025
@faucomte97
Copy link
Contributor Author

After careful consideration we have decided this task is no longer needed.

These 2 endpoints were created to deal with very specific issues, i.e. the empty schools and the fake accounts.
The empty schools issue has since been partially addressed with the addition of control systems around account deletion and teachers leaving schools to ensure that the school always gets anonymised when the last teacher deletes their account.
The fake accounts issue has, as far as I can tell, not occurred in a very long time.

Regardless, if either of these issues arise again, we should a) not rely on a cron-job which deletes data and b) tackle the issue at its source instead of dealing with the symptoms.

These would include things like adding further controls to ensure a school can never be empty and rely on stronger captchas or IP watchlists to deal with fake account creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2025:tech debt 2025 Goal: Reduce technical debt
Projects
Status: Closed
Development

No branches or pull requests

1 participant