Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

level editor: character change does not persist after road is randomly generated #1621

Open
evemartin opened this issue May 22, 2024 · 0 comments
Labels
bug cadets volunteers Tasks that can be picked up by anyone

Comments

@evemartin
Copy link
Contributor

evemartin commented May 22, 2024

Describe the bug
In some cases, even after selecting a different character in the Level Editor, when the level is saved and played it displays the default Van character.

To Reproduce

  1. Log in as any user and open the Level Editor
  2. Go to the Character tab and select a character other than Van

image

  1. Go to the Random tab and randomly generate a map

image

  1. (at this point, if you go back to the Character tab, the image will still be of the new character you chose but the dropdown value will be blank)
  2. Save the level and, when prompted, choose to play the level
  3. The character will be the Van and not the new character you chose

Expected behaviour
The level editor should remember the character choice even when recreating a new random road.

Once this has been fixed, please also check if changing other settings through the level editor also overwrites the character setting.

Good places to start

It seems like the function to generate the random road might be resetting the value of the character to the default, i.e. the van.

random_road.py: https://github.com/ocadotechnology/rapid-router/blob/master/game/random_road.py

@evemartin evemartin changed the title Setting non-van character sometimes doesn't work Switching to a non-van character in the Level Editor sometimes doesn't work May 22, 2024
@evemartin evemartin changed the title Switching to a non-van character in the Level Editor sometimes doesn't work level editor: character change does not persist after road is randomly generated May 22, 2024
@faucomte97 faucomte97 added bug volunteers Tasks that can be picked up by anyone cadets labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cadets volunteers Tasks that can be picked up by anyone
Projects
None yet
Development

No branches or pull requests

2 participants