Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Den levels page #1673

Closed
5 tasks
lauracumming opened this issue Jul 10, 2024 · 21 comments · Fixed by #1715
Closed
5 tasks

Python Den levels page #1673

lauracumming opened this issue Jul 10, 2024 · 21 comments · Fixed by #1715
Assignees

Comments

@lauracumming
Copy link

lauracumming commented Jul 10, 2024

Task Description

We would like to build the page for the Python Den levels - it will replicate Rapid Router levels page. In order to complete this task, the Python levels will be separated from RR, and the new mapping will be applied throughout. There will be levels that need remapping, and button with links to videos and resources.

Acceptance Criteria

  • Remove Python levels from Rapid Router levels page
  • Add Python levels to Python Hub levels page

Analytics Requirements

Copywrite Requirements

  • Copy for page is here

Note: There are different views for different users

@lauracumming
Copy link
Author

Updated designs for high level buildPython Den page with buttons closed.png
Python Den page with buttons open - Independent student view.png
Python Den page with buttons open - teacher view.png

@lauracumming
Copy link
Author

lauracumming commented Jul 25, 2024

Screenshot 2024-07-24 at 17.54.45.png

@lauracumming
Copy link
Author

Levels page - student

@lauracumming
Copy link
Author

lauracumming commented Jul 30, 2024

Python Den page with buttons open - student view.png

@evemartin
Copy link
Contributor

evemartin commented Aug 16, 2024

@lauracumming the String Manipulation episode doesn't have any traditional numbered levels in it but the Indeterminate Loops episode right before it does - when the user finishes the last level in the Indeterminate Loops episode, should they be able to go straight to the next level, skipping the String Manipulation episode entirely, or should they get some kind of other prompt to go back to the main levels page instead?

@lauracumming
Copy link
Author

Good question. It's tricky without the embedded text editor. Maybe go back to levels page and it opens the relevant section? Does that make sense?

@lauracumming
Copy link
Author

Then they have the option to either open the worksheet or skip?

@evemartin
Copy link
Contributor

Handover notes: there are just a few things left to do for this task!

  • there are still some resource links missing - right now these are marked with "TODO"
  • some parts of the PR can be optimised - some repeated bits of code in python_den_level_selection.html could be extracted into a custom HTML element, and there's one hardcoded worksheet/IDE level (at the end of the "Counted Loops Using While" episode that might be better if not hardcoded
  • we still need to add the functionality Laura mentioned above: when the user gets to the end of an episode that's followed by an episode with no levels, they should get directed back to the main level selection page instead of the next level (since that would skip over the next episode with no levels)

@lauracumming
Copy link
Author

Couldn't see these when I clicked to continue. I wasn't logged in - is this an edge case that we need different messaging for?

@lauracumming
Copy link
Author

LGTM (apart from 'next level')

@lauracumming
Copy link
Author

Broken link in Procedures episode

Image

@faucomte97
Copy link
Contributor

@lauracumming Can be updated in admin panel

@faucomte97
Copy link
Contributor

But actually since it's not fully deployed yet we should fix it in the initial migration

@faucomte97
Copy link
Contributor

@lauracumming @evemartin correct me if I'm wrong but it doesn't look like we have a worksheet for that?

@lauracumming
Copy link
Author

Ah let me take a look. It may have not saved

@lauracumming
Copy link
Author

Screenshot 2024-08-29 at 12 48 02
This is the list for the episodes

@lauracumming
Copy link
Author

lauracumming commented Aug 29, 2024

Why is the banner a different depth to RR levels page? Do you need a new image?

@faucomte97
Copy link
Contributor

Depth? You mean height? @evemartin

@evemartin
Copy link
Contributor

Oh yes, I think it's just the dimensions of the image - if you have another image for one of the headers that matches the other image's dimensions I can update! @lauracumming

@faucomte97 faucomte97 moved this from Staging to Production in Code for Life Kanban boards Aug 29, 2024
@lauracumming
Copy link
Author

LGTM, apart from I just noticed the styling for the inactive button isn't consistent with the newsletter button.

Image
Image

@faucomte97 faucomte97 linked a pull request Sep 3, 2024 that will close this issue
@faucomte97 faucomte97 moved this from Production to Closed in Code for Life Kanban boards Sep 4, 2024
@faucomte97 faucomte97 closed this as completed by moving to Closed in Code for Life Kanban boards Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

3 participants